Uh oh!
There was an error while loading. Please reload this page.
fix: default CallToolResult content to empty vec on missing field - #752
Merged
Conversation
DaleSeoforce-pushed
the
fix/call-tool-result-default-content
branch
from
March 12, 2026 23:46
18b3a23 to
044bff3CompareDaleSeo
marked this pull request as ready for review
March 12, 2026 23:53
jamadeo
approved these changes
Mar 13, 2026
jamadeo
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me. The only reason not to do this would be if an empty array would be semantically different from a missing one, but a) I don't think that's true, and b) it would not match the MCP schema anyway.
Uh oh!
There was an error while loading. Please reload this page.
Merged
10 tasks
DaleSeo added a commit
that referenced
this pull request
Mar 22, 2026
…ustomResult in untagged enums The `#[serde(default)]` on `CallToolResult.content` (added in #752) made all fields optional, causing `CallToolResult` to greedily match any JSON object during `#[serde(untagged)]` deserialization of `ServerResult`. Similarly, `GetTaskPayloadResult(Value)` matched everything before `CustomResult(Value)` could be reached. Fix by replacing derived `Deserialize` impls with custom ones: - `CallToolResult`: require at least one known field to be present - `GetTaskPayloadResult`: always fail (indistinguishable from `CustomResult` in JSON; construct programmatically via `::new()`)
Merged
9 tasks
DaleSeo added a commit
that referenced
this pull request
Mar 23, 2026
…ustomResult in untagged enums (#771) The `#[serde(default)]` on `CallToolResult.content` (added in #752) made all fields optional, causing `CallToolResult` to greedily match any JSON object during `#[serde(untagged)]` deserialization of `ServerResult`. Similarly, `GetTaskPayloadResult(Value)` matched everything before `CustomResult(Value)` could be reached. Fix by replacing derived `Deserialize` impls with custom ones: - `CallToolResult`: require at least one known field to be present - `GetTaskPayloadResult`: always fail (indistinguishable from `CustomResult` in JSON; construct programmatically via `::new()`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#750.
Motivation and Context
This PR restores lenient deserialization by adds
#[serde(default)]to thecontentfield of theCallToolResultconstruct.How Has This Been Tested?
Existing and new tests cover the change.
Breaking Changes
None. This is strictly more permissive. JSON payloads that previously deserialized successfully continue to work identically. Only payloads that previously failed (missing
content) now succeed.Types of changes
Checklist
Additional context