Skip to content

chore: run all tests in ci without "local" feature - #761

Merged
DaleSeo merged 1 commit into
modelcontextprotocol:mainfrom
binahm:chore/run-tests-non-local
Mar 23, 2026
Merged

chore: run all tests in ci without "local" feature#761
DaleSeo merged 1 commit into
modelcontextprotocol:mainfrom
binahm:chore/run-tests-non-local

Conversation

@glicht

@glichtglicht commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

There are many tests that don't run when "local" feature is enabled. These tests were not being run in CI as the tests job runs with all features including "local" and many tests have not(feature = "local") gate which means they don't run with --all-features flag.

Added an additional job: Run Tests (no local feature) which runs all tests without the local feature.

There is one tests that is failing: test_custom_client_request_reaches_server. That needs to be fixed.

Local feature was added here during this PR

How Has This Been Tested?

Runs in CI

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Chore

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@glicht
glicht requested a review from a team as a code ownerMarch 19, 2026 19:07
@github-actionsgithub-actionsBot added T-CI Changes to CI/CD workflows and configuration T-config Configuration file changes labels Mar 19, 2026
@DaleSeo

Copy link
Copy Markdown
Member

Hi @glicht, could you check the failing test in CI?

alexhancock
alexhancock previously approved these changes Mar 20, 2026
@alexhancock

Copy link
Copy Markdown
Contributor

yeah, agree with @DaleSeo. if you could please check out

test test_custom_client_request_reaches_server ... FAILED

then this LGTM

@glicht

Copy link
Copy Markdown
ContributorAuthor

@DaleSeo from what it looks like your PR at: #752 is the cause for the failing test. Didn't get a chance to look why exactly the test is failing. Maybe you can take a look?

@DaleSeo

Copy link
Copy Markdown
Member

Hey @glicht, my fix has been merged. Do you mind rebasing your branch off of the latest main? Then, I think your test will pass.

@glicht

Copy link
Copy Markdown
ContributorAuthor

Hey @glicht, my fix has been merged. Do you mind rebasing your branch off of the latest main? Then, I think your test will pass.

Will do. Thanks.

@glicht

Copy link
Copy Markdown
ContributorAuthor

Note that I also update the justfile so "just test" runs both local and non-local tests.

@DaleSeo
DaleSeo merged commit baf22d3 into modelcontextprotocol:mainMar 23, 2026
17 checks passed
@glicht
glicht deleted the chore/run-tests-non-local branch March 30, 2026 18:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-CIChanges to CI/CD workflows and configurationT-configConfiguration file changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@glicht@DaleSeo@alexhancock@rezaagolmohamadi35-tech