Uh oh!
There was an error while loading. Please reload this page.
chore(ci): remove dead publish job from main.yml - #1829
Merged
Conversation
The publish job runs `pnpm publish` from the workspace root, which has `private: true` — structurally can't succeed since the monorepo conversion. It triggers on `on: release` which fires 5× when changesets creates one GitHub Release per package, producing 5 red X per release. release.yml is the real publish path. v1.x is unaffected: it has its own main.yml in its own tree, and on:release loads workflow YAML from the tagged commit, not the default branch.
|
@modelcontextprotocol/client@modelcontextprotocol/server@modelcontextprotocol/express@modelcontextprotocol/fastify@modelcontextprotocol/hono@modelcontextprotocol/nodecommit: |
KKonstantinov
approved these changes
Mar 31, 2026
felixweinberger
enabled auto-merge (squash)
March 31, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the
on: releasetrigger and the entirepublishjob frommain.yml. 52 lines removed.Motivation and Context
The
publishjob runspnpm publishfrom the workspace root, which has"private": true— it has structurally never succeeded since the monorepo conversion and never will.It triggers on
on: release: types: [published]. When the Version Packages PR merges andchangeset publishcreates 5 GitHub Releases (one per package), this fires 5 times: 5environment: releaseapproval prompts (if configured), ~30 redundant build/test jobs (needs: [build, test, test-runtimes]re-runs CI that already passed on the push), then 5 red X onpnpm publishhittingprivate: true.The packages are already published by
release.ymlvia changesets/action by this point. This is v1-era single-package machinery that never got removed.Also takes out the latent
-beta-not--alphabug in the npm-tag step (reads root package.json which changesets doesn't bump, checks-betabut not-alpha) — currently masked by the enclosing failure but dangerous if anyone copies it.v1.x is unaffected.
on: releaseloads workflow YAML from the tagged commit's tree, not the default branch. v1.x tags point at v1.x commits which have their ownmain.ymlwith the publish job intact (where it works — v1.x root is@modelcontextprotocol/sdk, not private).How Has This Been Tested?
Workflow YAML only — CI validates syntax. Verified no
release:orpublish:strings remain in the file.Breaking Changes
None.
Types of changes
Checklist
Additional context
Follow-ups (not in this PR, tracked in the audit doc at
~/src/mcp/docs/2026-03-31-release-workflow-audit.md):environment: releasegate torelease.yml— currently protects nothing, real publish is ungatedrelease.yml(id-token: write+NPM_CONFIG_PROVENANCE: "true")gh release create)