Skip to content

publishConfig access public fix - #1837

Closed
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config
Closed

publishConfig access public fix#1837
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@KKonstantinov
KKonstantinov requested a review from a team as a code ownerApril 1, 2026 14:30
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aba45ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1837

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1837

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1837

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/fastify@1837

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1837

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1837

commit: aba45ec

@claudeclaudeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of publishConfig: { access: "public" } to all scoped packages to ensure they publish correctly to npm.

Extended reasoning...

Overview

This PR adds "publishConfig": { "access": "public" } to the package.json of six scoped packages: @modelcontextprotocol/client, @modelcontextprotocol/server, and the four middleware packages (express, fastify, hono, node). The change is identical across all six files and is purely additive — no logic, no tests, no runtime behavior is modified.

Security Risks

None. This is a package metadata change that only affects how npm publish behaves. It explicitly sets the npm publish access to public, which is the standard requirement for scoped packages (@scope/name) to be published to the public npm registry. Without this field, scoped packages default to restricted (private), which would cause publish failures unless the org has paid npm access configured. There is no security concern here.

Level of Scrutiny

Minimal scrutiny required. This is a mechanical, well-understood npm configuration fix. The pattern is identical in all six files, the field values are correct, and the fix directly matches the PR title. The recent commit history shows a sibling fix (#1836, #1833, #1829) around CI/release configuration, so this fits the same housekeeping pattern.

Other Factors

No bugs were found by the bug hunting system. No prior reviews exist on this PR. The changeset-bot note about no changeset is acceptable here since publishConfig is infrastructure metadata, not a user-facing API change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KKonstantinov
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
publishConfig access public fix by KKonstantinov · Pull Request #1837 · modelcontextprotocol/typescript-sdk · GitHub
Skip to content

publishConfig access public fix - #1837

Closed
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config
Closed

publishConfig access public fix#1837
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@KKonstantinov
KKonstantinov requested a review from a team as a code ownerApril 1, 2026 14:30
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aba45ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1837

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1837

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1837

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/fastify@1837

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1837

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1837

commit: aba45ec

@claudeclaudeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of publishConfig: { access: "public" } to all scoped packages to ensure they publish correctly to npm.

Extended reasoning...

Overview

This PR adds "publishConfig": { "access": "public" } to the package.json of six scoped packages: @modelcontextprotocol/client, @modelcontextprotocol/server, and the four middleware packages (express, fastify, hono, node). The change is identical across all six files and is purely additive — no logic, no tests, no runtime behavior is modified.

Security Risks

None. This is a package metadata change that only affects how npm publish behaves. It explicitly sets the npm publish access to public, which is the standard requirement for scoped packages (@scope/name) to be published to the public npm registry. Without this field, scoped packages default to restricted (private), which would cause publish failures unless the org has paid npm access configured. There is no security concern here.

Level of Scrutiny

Minimal scrutiny required. This is a mechanical, well-understood npm configuration fix. The pattern is identical in all six files, the field values are correct, and the fix directly matches the PR title. The recent commit history shows a sibling fix (#1836, #1833, #1829) around CI/release configuration, so this fits the same housekeeping pattern.

Other Factors

No bugs were found by the bug hunting system. No prior reviews exist on this PR. The changeset-bot note about no changeset is acceptable here since publishConfig is infrastructure metadata, not a user-facing API change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KKonstantinov
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' publishConfig access public fix by KKonstantinov · Pull Request #1837 · modelcontextprotocol/typescript-sdk · GitHub
Skip to content

publishConfig access public fix - #1837

Closed
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config
Closed

publishConfig access public fix#1837
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@KKonstantinov
KKonstantinov requested a review from a team as a code ownerApril 1, 2026 14:30
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aba45ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1837

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1837

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1837

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/fastify@1837

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1837

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1837

commit: aba45ec

@claudeclaudeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of publishConfig: { access: "public" } to all scoped packages to ensure they publish correctly to npm.

Extended reasoning...

Overview

This PR adds "publishConfig": { "access": "public" } to the package.json of six scoped packages: @modelcontextprotocol/client, @modelcontextprotocol/server, and the four middleware packages (express, fastify, hono, node). The change is identical across all six files and is purely additive — no logic, no tests, no runtime behavior is modified.

Security Risks

None. This is a package metadata change that only affects how npm publish behaves. It explicitly sets the npm publish access to public, which is the standard requirement for scoped packages (@scope/name) to be published to the public npm registry. Without this field, scoped packages default to restricted (private), which would cause publish failures unless the org has paid npm access configured. There is no security concern here.

Level of Scrutiny

Minimal scrutiny required. This is a mechanical, well-understood npm configuration fix. The pattern is identical in all six files, the field values are correct, and the fix directly matches the PR title. The recent commit history shows a sibling fix (#1836, #1833, #1829) around CI/release configuration, so this fits the same housekeeping pattern.

Other Factors

No bugs were found by the bug hunting system. No prior reviews exist on this PR. The changeset-bot note about no changeset is acceptable here since publishConfig is infrastructure metadata, not a user-facing API change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KKonstantinov
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' publishConfig access public fix by KKonstantinov · Pull Request #1837 · modelcontextprotocol/typescript-sdk · GitHub
Skip to content

publishConfig access public fix - #1837

Closed
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config
Closed

publishConfig access public fix#1837
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@KKonstantinov
KKonstantinov requested a review from a team as a code ownerApril 1, 2026 14:30
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aba45ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1837

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1837

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1837

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/fastify@1837

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1837

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1837

commit: aba45ec

@claudeclaudeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of publishConfig: { access: "public" } to all scoped packages to ensure they publish correctly to npm.

Extended reasoning...

Overview

This PR adds "publishConfig": { "access": "public" } to the package.json of six scoped packages: @modelcontextprotocol/client, @modelcontextprotocol/server, and the four middleware packages (express, fastify, hono, node). The change is identical across all six files and is purely additive — no logic, no tests, no runtime behavior is modified.

Security Risks

None. This is a package metadata change that only affects how npm publish behaves. It explicitly sets the npm publish access to public, which is the standard requirement for scoped packages (@scope/name) to be published to the public npm registry. Without this field, scoped packages default to restricted (private), which would cause publish failures unless the org has paid npm access configured. There is no security concern here.

Level of Scrutiny

Minimal scrutiny required. This is a mechanical, well-understood npm configuration fix. The pattern is identical in all six files, the field values are correct, and the fix directly matches the PR title. The recent commit history shows a sibling fix (#1836, #1833, #1829) around CI/release configuration, so this fits the same housekeeping pattern.

Other Factors

No bugs were found by the bug hunting system. No prior reviews exist on this PR. The changeset-bot note about no changeset is acceptable here since publishConfig is infrastructure metadata, not a user-facing API change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KKonstantinov
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' publishConfig access public fix by KKonstantinov · Pull Request #1837 · modelcontextprotocol/typescript-sdk · GitHub
Skip to content

publishConfig access public fix - #1837

Closed
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config
Closed

publishConfig access public fix#1837
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@KKonstantinov
KKonstantinov requested a review from a team as a code ownerApril 1, 2026 14:30
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aba45ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1837

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1837

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1837

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/fastify@1837

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1837

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1837

commit: aba45ec

@claudeclaudeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of publishConfig: { access: "public" } to all scoped packages to ensure they publish correctly to npm.

Extended reasoning...

Overview

This PR adds "publishConfig": { "access": "public" } to the package.json of six scoped packages: @modelcontextprotocol/client, @modelcontextprotocol/server, and the four middleware packages (express, fastify, hono, node). The change is identical across all six files and is purely additive — no logic, no tests, no runtime behavior is modified.

Security Risks

None. This is a package metadata change that only affects how npm publish behaves. It explicitly sets the npm publish access to public, which is the standard requirement for scoped packages (@scope/name) to be published to the public npm registry. Without this field, scoped packages default to restricted (private), which would cause publish failures unless the org has paid npm access configured. There is no security concern here.

Level of Scrutiny

Minimal scrutiny required. This is a mechanical, well-understood npm configuration fix. The pattern is identical in all six files, the field values are correct, and the fix directly matches the PR title. The recent commit history shows a sibling fix (#1836, #1833, #1829) around CI/release configuration, so this fits the same housekeeping pattern.

Other Factors

No bugs were found by the bug hunting system. No prior reviews exist on this PR. The changeset-bot note about no changeset is acceptable here since publishConfig is infrastructure metadata, not a user-facing API change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KKonstantinov
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' publishConfig access public fix by KKonstantinov · Pull Request #1837 · modelcontextprotocol/typescript-sdk · GitHub
Skip to content

publishConfig access public fix - #1837

Closed
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config
Closed

publishConfig access public fix#1837
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@KKonstantinov
KKonstantinov requested a review from a team as a code ownerApril 1, 2026 14:30
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aba45ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1837

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1837

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1837

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/fastify@1837

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1837

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1837

commit: aba45ec

@claudeclaudeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of publishConfig: { access: "public" } to all scoped packages to ensure they publish correctly to npm.

Extended reasoning...

Overview

This PR adds "publishConfig": { "access": "public" } to the package.json of six scoped packages: @modelcontextprotocol/client, @modelcontextprotocol/server, and the four middleware packages (express, fastify, hono, node). The change is identical across all six files and is purely additive — no logic, no tests, no runtime behavior is modified.

Security Risks

None. This is a package metadata change that only affects how npm publish behaves. It explicitly sets the npm publish access to public, which is the standard requirement for scoped packages (@scope/name) to be published to the public npm registry. Without this field, scoped packages default to restricted (private), which would cause publish failures unless the org has paid npm access configured. There is no security concern here.

Level of Scrutiny

Minimal scrutiny required. This is a mechanical, well-understood npm configuration fix. The pattern is identical in all six files, the field values are correct, and the fix directly matches the PR title. The recent commit history shows a sibling fix (#1836, #1833, #1829) around CI/release configuration, so this fits the same housekeeping pattern.

Other Factors

No bugs were found by the bug hunting system. No prior reviews exist on this PR. The changeset-bot note about no changeset is acceptable here since publishConfig is infrastructure metadata, not a user-facing API change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KKonstantinov
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); publishConfig access public fix by KKonstantinov · Pull Request #1837 · modelcontextprotocol/typescript-sdk · GitHub
Skip to content

publishConfig access public fix - #1837

Closed
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config
Closed

publishConfig access public fix#1837
KKonstantinov wants to merge 1 commit into
mainfrom
fix/publish-config

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@KKonstantinov
KKonstantinov requested a review from a team as a code ownerApril 1, 2026 14:30
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aba45ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1837

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1837

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1837

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/fastify@1837

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1837

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1837

commit: aba45ec

@claudeclaudeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of publishConfig: { access: "public" } to all scoped packages to ensure they publish correctly to npm.

Extended reasoning...

Overview

This PR adds "publishConfig": { "access": "public" } to the package.json of six scoped packages: @modelcontextprotocol/client, @modelcontextprotocol/server, and the four middleware packages (express, fastify, hono, node). The change is identical across all six files and is purely additive — no logic, no tests, no runtime behavior is modified.

Security Risks

None. This is a package metadata change that only affects how npm publish behaves. It explicitly sets the npm publish access to public, which is the standard requirement for scoped packages (@scope/name) to be published to the public npm registry. Without this field, scoped packages default to restricted (private), which would cause publish failures unless the org has paid npm access configured. There is no security concern here.

Level of Scrutiny

Minimal scrutiny required. This is a mechanical, well-understood npm configuration fix. The pattern is identical in all six files, the field values are correct, and the fix directly matches the PR title. The recent commit history shows a sibling fix (#1836, #1833, #1829) around CI/release configuration, so this fits the same housekeeping pattern.

Other Factors

No bugs were found by the bug hunting system. No prior reviews exist on this PR. The changeset-bot note about no changeset is acceptable here since publishConfig is infrastructure metadata, not a user-facing API change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@KKonstantinov