Skip to content

CostTerms: joint-weighted costs, expose to python - #409

Merged
rhaschke merged 5 commits into
masterfrom
cost-terms
Dec 11, 2022
Merged

CostTerms: joint-weighted costs, expose to python#409
rhaschke merged 5 commits into
masterfrom
cost-terms

Conversation

@rhaschke

Copy link
Copy Markdown
Contributor

This implements joint-specific weighting of PathLength and DistanceToReference (new) costs.
Also expose cost stuff to python.

@rhaschke

rhaschke commented Dec 9, 2022

Copy link
Copy Markdown
ContributorAuthor

Hm. The segfaulting tests seem to stem from pybind11 issues in a Debug build: pybind/pybind11#4395

@codecov

codecovBot commented Dec 11, 2022

Copy link
Copy Markdown

Codecov Report

Base: 59.03% // Head: 58.97% // Decreases project coverage by -0.07%⚠️

Coverage data is based on head (8faf416) compared to base (de22cba).
Patch coverage: 39.03% of modified lines in pull request are covered.

❗ Current head 8faf416 differs from pull request most recent head 7c35f6c. Consider uploading reports for the commit 7c35f6c to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## master #409 +/- ##
==========================================
- Coverage 59.03% 58.97% -0.06% 
==========================================
Files 94 94 Lines 8322 8436 +114 ==========================================
+ Hits 4912 4974 +62 - Misses 3410 3462 +52 
Impacted FilesCoverage Δ
core/include/moveit/task_constructor/task.h25.00% <ø> (ø)
core/src/cost_terms.cpp24.12% <4.17%> (-8.69%)⬇️
core/python/bindings/src/core.cpp87.88% <87.50%> (-0.32%)⬇️
core/include/moveit/task_constructor/cost_terms.h85.72% <100.00%> (-14.28%)⬇️
core/python/bindings/src/core.h54.17% <100.00%> (-9.46%)⬇️
core/python/bindings/src/solvers.cpp93.11% <0.00%> (-2.89%)⬇️
core/include/moveit/task_constructor/cost_queue.h97.68% <0.00%> (-2.32%)⬇️
core/include/moveit/task_constructor/storage.h86.96% <0.00%> (-0.95%)⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rhaschke
rhaschkeforce-pushed the cost-terms branch 2 times, most recently from 334c6c0 to f2b7691CompareDecember 11, 2022 11:09
@rhaschke
rhaschkeforce-pushed the cost-terms branch 2 times, most recently from 8faf416 to 7c35f6cCompareDecember 11, 2022 20:36
@rhaschke
rhaschke merged commit 26c690c into masterDec 11, 2022
@rhaschke
rhaschke deleted the cost-terms branch January 4, 2023 22:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rhaschke