mercurial: refactor how we handle retries. - #102
Merged
Merged
Conversation
suhaibmujahid
approved these changes
Jun 29, 2023
suhaibmujahid
left a comment
Member
There was a problem hiding this comment.
LGTM! I guess reading error_log from the parent scope was causing problems. Thank you for fixing it.
Comment on lines
+404
to
+408
| eligible_errors = [ | ||
| "push failed on remote", | ||
| "stream ended unexpectedly", | ||
| "error: EOF occurred in violation of protocol", | ||
| ] |
Member
There was a problem hiding this comment.
nit: eligible_errors could be moved to be a class or module constant (could be named ELIGIBLE_RETRY_ERRORS)
Comment on lines
+409
to
+412
| for eligible_message in eligible_errors: | ||
| if eligible_message in error: | ||
| return True | ||
| return False |
Member
There was a problem hiding this comment.
nit: since you are refactoring this part, using any() would be more pythonic
Suggested change
| for eligible_message in eligible_errors: | |
| if eligible_message in error: | |
| return True | |
| return False | |
| return any(eligible_message in error for eligible_message in eligible_errors) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a refactor on how to handle retries for mercurial.