mercurial: fix the case insensitive matching when handling retry errors - #103
Conversation
| "push failed on remote", | ||
| "stream ended unexpectedly", | ||
| "error: EOF occurred in violation of protocol", | ||
| "error: eof occurred in violation of protocol", |
There was a problem hiding this comment.
@abpostelnicu sorry I did not catch this in the review of #102 :(
There was a problem hiding this comment.
Let's not do this. Since as we tend to see in the logs new error messages we add them to the list and by doing so this would mean to do the lower by hand.
There was a problem hiding this comment.
I changed it in 84664f2 to be done automatically.
| "push failed on remote", | ||
| "stream ended unexpectedly", | ||
| "error: EOF occurred in violation of protocol", | ||
| "error: eof occurred in violation of protocol", |
There was a problem hiding this comment.
Let's not do this. Since as we tend to see in the logs new error messages we add them to the list and by doing so this would mean to do the lower by hand.
| ] | ||
| error = error.lower() | ||
| for eligible_message in eligible_errors: | ||
| if eligible_message in error: |
There was a problem hiding this comment.
this should be eligible_message.lower()
There was a problem hiding this comment.
this replaces lower() in self.is_eligible_for_retry(error_log.lower())
This is a followup on #102