Skip to content

Unpin ecdsa - #192

Merged
blag merged 2 commits into
mpdavis:masterfrom
przemyslaw-jakielaszek:master
Nov 23, 2020
Merged

Unpin ecdsa#192
blag merged 2 commits into
mpdavis:masterfrom
przemyslaw-jakielaszek:master

Conversation

@przemyslaw-jakielaszek

@przemyslaw-jakielaszekprzemyslaw-jakielaszek commented Oct 22, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

There is a newer version of ecdsa 0.16.0. We can unpin version, because all of tests passed.

@codecov

codecovBot commented Oct 22, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #192 (fcae04f) into master (82bd8aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #192 +/- ##
=======================================
Coverage 93.51% 93.51% =======================================
Files 16 16 Lines 1728 1728 =======================================
Hits 1616 1616 Misses 112 112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82bd8aa...fcae04f. Read the comment docs.

@m-aciek

m-aciek commented Oct 30, 2020

Copy link
Copy Markdown

Hi @blag, could you review and merge the change? It looks like new version of ecdsa gives some performance boost.

@Colin-b

Colin-b commented Nov 18, 2020

Copy link
Copy Markdown

Hello maintainers, can you have a look at this? the new pip resolver will prevent usage of ecdsa 0.16 even if it can be used with python-jose.

@blag

blag commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

NAK. Just because the most recent version of ecdsa works for us doesn't mean that 0.15 won't mess things up somehow. We still need to blacklist ecdsa 0.15: ecdsa != 0.15.

blag
blag suggested changes Nov 19, 2020
View reviewed changes
Comment threadrequirements.txt Outdated
@blagblag mentioned this pull request Nov 19, 2020
Open
@blagblag added dependencies Pull requests that update a dependency file enhancement help wanted labels Nov 19, 2020
@przemyslaw-jakielaszek@blag
Blacklist ecdsa 0.15
fcae04f
Co-authored-by: blag <blag@users.noreply.github.com>
@blag
blag merged commit a2a4c31 into mpdavis:masterNov 23, 2020
@blag

blag commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

Thanks!

dreid added a commit to dreid/python-jose that referenced this pull request Nov 30, 2020
@dreid
Denylist ecdsa 0.15 in setup.py to allow for 0.16 to be installed.
368a2ad
The previous pull request mpdavis#192 only changed the pin in requirements.txt and not in setup.py, so the ecdsa<0.15 restriction would actually be used by pip.
@dreiddreid mentioned this pull request Nov 30, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@blagblagblag approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependenciesPull requests that update a dependency fileenhancementhelp wanted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@przemyslaw-jakielaszek@m-aciek@Colin-b@blag