Denylist ecdsa 0.15 in setup.py to allow for 0.16 to be installed. - #199
Merged
Conversation
The previous pull request mpdavis#192 only changed the pin in requirements.txt and not in setup.py, so the ecdsa<0.15 restriction would actually be used by pip.
blag
commented
Dec 7, 2020
Contributor
Codecov Report
@@ Coverage Diff @@## master #199 +/- ##
=======================================
Coverage 93.51% 93.51% =======================================
Files 16 16 Lines 1728 1728 =======================================
Hits 1616 1616 Misses 112 112
Continue to review full report at Codecov.
|
blag
commented
Dec 8, 2020
Contributor
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous pull request #192 only changed the pin in requirements.txt and not in setup.py, so the ecdsa<0.15 restriction would actually be used by pip.