Improved availability and HVAC action logic in ComfoClimeClimate - #25
Improved availability and HVAC action logic in ComfoClimeClimate#25Revilo91 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to improve the availability logic and HVAC action handling in the ComfoClime climate integration by using bitwise operations to return multiple HVAC actions simultaneously. However, the changes introduce several critical issues that break compatibility with Home Assistant's ClimateEntity API.
Key changes:
- Modified availability check to use OR logic between two coordinators
- Changed hvac_action return type from single HVACAction to list[HVACAction]
- Rewrote bitwise logic to return multiple active states simultaneously
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I've been experimenting a bit with bitwise operations and came up with the following.
Since Hassio allows passing multiple HVACActions, I programmed this and it's currently in use in my system.Addendum:
The documentation states that only a status needs to be returned, but the frontend processes this correctly -> (https://github.com/home-assistant/frontend/blob/eb74dd541a6c98b994c98144045ee851156f0f46/src/common/entity/compute_attribute_display.ts#L97).
I think that if ComfoClime is already providing this information, it should at least be displayed.