Services: target device selection (multi-device support) - #35
Open
helgeklein wants to merge 3 commits into
Open
Conversation
Adds target device selection to the reset service so it's possible to specify which device to reset.
Implemented shared multi-instance service routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two services,
set_propertyandreset_systemdidn't support multiple ComfoClime devices. The issues were as follows:reset_system: only the first ComfoClime device would be resetset_property: the request would be sent to the last registered handlerThis PR adds target device selectors to both services.