Uh oh!
There was an error while loading. Please reload this page.
fix: Limit active-icon inversion to legacy nav design - #2585
Closed
nfebe wants to merge 1 commit into
Closed
Conversation
On the new tinted active background the inversion flips icons to white on a light surface. Now scoped to the legacy design only. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
commented
May 9, 2026
ContributorAuthor
Closing this — opened in error, not a fix that should live in this app. Apologies for the noise. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Activity | ||||||||||||||||||||||||||||
| Project | Activity |
| Branch Review | fix/active-icon-inversion-tinted-bg |
| Run status | |
| Run duration | 02m 02s |
| Commit | |
| Committer | F. E Noel Nfebe |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 | 0 |
 | 0 |
 | 1 |
 | 0 |
 | 9 |
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Nextcloud 34+ the active app-navigation entry background is a soft tinted color rather than the previous solid primary. The existing icon-filter inverts to white assuming the old dark primary background, so on the new design active icons render white on a light tint.
This restricts the inverted filter to the legacy nav design (NC < 34), where the active background is still the solid primary and the inversion is correct. On the new design, active icons keep the regular background-aware filter.
Same fix shape as nextcloud/server#60243 for the equivalent regression in Settings.
Test plan