Skip to content

fix(settings): remove legacy handling of active navigation settings icon - #60243

Merged
susnux merged 2 commits into
masterfrom
fix/settings-icon
May 12, 2026
Merged

fix(settings): remove legacy handling of active navigation settings icon#60243
susnux merged 2 commits into
masterfrom
fix/settings-icon

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Summary

On the new tinted active background the inversion flips icons to white on a light surface.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux
susnux requested a review from a team as a code ownerMay 8, 2026 14:27
@susnux
susnux requested review from nfebe, skjnldsv and sorbaugh and removed request for a teamMay 8, 2026 14:27
@susnuxsusnux changed the title fix(settings): Limit active-icon inversion to legacy nav designfix(settings): remove legacy handling of active navigation settings icoMay 8, 2026
@susnuxsusnux added this to the Nextcloud 34 milestone May 8, 2026
@susnuxsusnux added bug 3. to review Waiting for reviews labels May 8, 2026
@nfebe

nfebe commented May 8, 2026

Copy link
Copy Markdown
Contributor

/compile

@susnuxsusnux changed the title fix(settings): remove legacy handling of active navigation settings icofix(settings): remove legacy handling of active navigation settings iconMay 11, 2026
@susnux
susnuxforce-pushed the fix/settings-icon branch from 22156cd to dba97bdCompareMay 11, 2026 11:18
nfebeand others added 2 commits May 12, 2026 12:32
On the new tinted active background the inversion flips icons to
white on a light surface. Now scoped to the legacy design only.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the fix/settings-icon branch from dba97bd to b015a4cCompareMay 12, 2026 10:32
@susnux
susnux merged commit 4ffcb2a into masterMay 12, 2026
204 of 222 checks passed
@susnux
susnux deleted the fix/settings-icon branch May 12, 2026 17:26
This was referenced May 12, 2026
@nextcloud-botnextcloud-bot mentioned this pull request May 20, 2026
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@nfebe@skjnldsv@nextcloud-command