Uh oh!
There was an error while loading. Please reload this page.
Ensure link names are unique for accessibility, thanks @nickvergessen, fix #575 - #576
Merged
Conversation
jancborchardt
commented
Apr 13, 2021
MemberAuthor
/backport to stable21 |
nickvergessen
requested changes
Apr 13, 2021
Uh oh!
There was an error while loading. Please reload this page.
jancborchardtforce-pushed
the
design/fix-linkname
branch
2 times, most recently
from
April 13, 2021 17:51
115421f to
8cae3c1Compare…ix#575 Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
nickvergessenforce-pushed
the
design/fix-linkname
branch
from
April 14, 2021 11:00
8cae3c1 to
38a31e5Comparenickvergessen
approved these changes
Apr 14, 2021
nickvergessen
commented
Apr 14, 2021
Member
Pushed a fix to the unit tests |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
design/fix-linkname
branch
from
April 14, 2021 13:42
e53e216 to
1463a74Compare| 'isMimeTypeIcon' => true, | ||
| 'fileId' => $fileId, | ||
| 'view' => $info['view'] ?: 'files', | ||
| 'filename' => basename($filePath), |
Member
There was a problem hiding this comment.
@nickvergessen This is an REST API change, shouldn't it be documented?
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, there were a lot of duplicate links on the page all saying "Open file", which makes it a problem for screen readers:
This is now fixed by changing the link to say "Open
filename" stating the actual filename.Since the links are already there in text form directly above, in the future we could also remove the duplicate linked images from screenreader flow by using divs for them and triggering the link via Javascript.