Uh oh!
There was an error while loading. Please reload this page.
Add filename in the preview docs - #588
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
May 12, 2021
I just wonder why this is added to the preview and not to the element itself 🤔 |
MorrisJobke
commented
May 12, 2021
ref #576 |
MorrisJobke
commented
May 12, 2021
@nickvergessen Tobias wondered yesterday if this should be seen as breaking change? There are JSON parsers out there that also break if new elements are added. |
nickvergessen
commented
May 12, 2021
Adding additional items is per semver not a breaking change, so it should be fine. No need to duplicate the API unnecessarily.
Because the preview object is disconnected from the files object (not every file can has a preview) and it was just easier this way to inject the data on the level it is needed and available instead of starting to map values later on. |
tobiasKaminsky
commented
May 17, 2021
ok, did not knew this. I already checked with other clients to see that everything is working. |
cc @jancborchardt@tobiasKaminsky@nickvergessen
For https://github.com/nextcloud/activity/pull/576/files#r630185430