Uh oh!
There was an error while loading. Please reload this page.
Gallery search - #147
Conversation
AndyScherzinger
commented
May 25, 2018
code-wise it looks fine to me, is there a corresponding app branch where this is integrated? |
mario
commented
May 25, 2018
@AndyScherzinger I just did a quick hack for the app to test this while developing, there's no corresponding app branch since someone else will have to do it. The reason is that over a year ago we agreed to merge videos+photos into a Gallery both into iOS and Android, so I had to see how to do it. This PR is the result of it :) |
AndyScherzinger
commented
May 25, 2018
@mario could you just push your hack to a branch on the app repo, that we I/we would have an impression of how to integrate and could pick it up from there :) That be of great help :) |
mario
commented
May 30, 2018
@AndyScherzinger I deleted this as it was literally a few lines change to send GALLERY_SEARCH over to the SearchOperation. :-/ |
tobiasKaminsky
commented
May 30, 2018
After release of 3.2 I can have a look to implement it in app. |
mario
commented
May 30, 2018
Well, didn't we talk about search pagination and caching the proper way @icewind1991? :P |
AndyScherzinger
commented
May 30, 2018
@tobiasKaminsky@mario for whatever reason the iOS client is super fast for this view?! |
tobiasKaminsky
commented
May 30, 2018
There is already some work done by Roeland and me: nextcloud/android#2250 |
AndyScherzinger
commented
May 30, 2018
@tobiasKaminsky iOS is super fast now! Not needing any Nc14 stuff, so that doesn't matter it seems that this can be solved today... |
tobiasKaminsky
commented
Jun 1, 2018
nextcloud/ios#583 |
mario
commented
Jun 9, 2018
I need review on this @AndyScherzinger@tobiasKaminsky@ardevd |
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
58b4cae to
b40082fCompare
Videos + Photos need to be merged into one item as gallery. This adds library support for it.
cc @ardevd@AndyScherzinger@tobiasKaminsky