Uh oh!
There was an error while loading. Please reload this page.
Use reloading on photo view - #2250
Conversation
c9f6c5c to
d4bed02ComparetobiasKaminsky
commented
Mar 13, 2018
This will be a NC14+ feature as it depends on changes on webdav search. |
89b8829 to
fc0e389Compare9c9b1a4 to
32e5835CompareAndyScherzinger
commented
May 15, 2018
@tobiasKaminsky is this PR revive-able? Just asking because RecyclerView has already been merged and this PR has a lot of conflicts with master :/ |
tobiasKaminsky
commented
May 16, 2018
I will try, once I have a bit space left. |
AndyScherzinger
commented
May 16, 2018
recyclerview PR has already been merged, so maybe a rebase on master will solve most of the issues automatically? |
tobiasKaminsky
commented
Aug 12, 2019
@ezaquarii I changed code according to your review, thank you :-) |
Uh oh!
There was an error while loading. Please reload this page.
| import java.lang.ref.WeakReference; | ||
| public class PhotoSearchTask extends AsyncTask<Void, Void, RemoteOperationResult> { |
There was a problem hiding this comment.
We could consider migrating this to new AsyncRunner. Few benefits:
- task turns into a simple function which you can actually unit test
onPostExectuteturns into another function and moves to relevant UI class where it belongs
There was a problem hiding this comment.
Let us do this in an additional PR.
This one is already too old and too big.
| @Override | ||
| protected void onPostExecute(RemoteOperationResult result) { | ||
| if (photoFragmentWeakReference.get() != null) { |
There was a problem hiding this comment.
I'm not sure ithis UI code belongs here.
There was a problem hiding this comment.
Let us also do this in the same new PR as above.
Uh oh!
There was an error while loading. Please reload this page.
Just tested the latest 10374.apk build. First, selecting the images section in the left panel seemed to load faster than previous test-build, buf it loaded only 13 images (quite old, not the latest one that I have taken with my phone or uploaded on my account...), and then stopped, with the loading spinning wheel. Switching to other app. and coming back to ND and selecting the images section in the left panel does nothing good, i.e. only showing 13 grey icons. Doing the same thing again show the 13 images that were first displayed, without nothing else except showing the loading spinning wheel. |
tobiasKaminsky
commented
Aug 16, 2019
Spotbugs fails to detect logic here: I check at L96 if it is null, and then use it at 115, where it can never been null. No idea what to do here to prevent Spotbugs from behaving wrong. |
- cache query for 30s - show progressbar if loading more Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
nextcloud-android-bot
commented
Aug 16, 2019
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10407.apk |
nextcloud-android-bot
commented
Aug 16, 2019
Codacy276Lint
SpotBugs (new)
SpotBugs (master)
|
nextcloud-android-bot
commented
Aug 16, 2019
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10407 |
tobiasKaminsky
commented
Aug 16, 2019
@ezaquarii@AndyScherzinger I would like to get this into 3.8.0 RC1, which is scheduled for next Monday. |
tobiasKaminsky
commented
Aug 16, 2019
IT test failure are unrelated. |
AndyScherzinger
commented
Aug 16, 2019
Fine with me : |
AndyScherzinger
commented
Aug 17, 2019
Awaiting feedback from @ezaquarii :) |
mlaverdiere
commented
Aug 17, 2019
I just tried the latest 10407.apk and it works way better than the previous 10374.apk (and that the current stable release): pictures are loading (relatively...) fast the first time the pictures section is clicked and when coming back, it's much (relatively...) faster since it seems it doesn't try to reload completely the pictures but instead relie on cache data. Also, pictures are displayed in some logical order, i.e. pictures last taken (or modified/loaded I guess) are displayed first. I would say that, at last, with these fixes, the pictures section of the ND app. would be usable. Thanks! |
nextcloud-android-bot
commented
Aug 17, 2019
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10424.apk |
Oops.. I did some other tests (with 10407.apk) that were not so conclusive: upon exiting and coming back to the ND app, only grey icons were displayed in the pictures section and eventually, the app. crashed repetitively... Once I could get the pictures showing up again, it seemed that after it managed to display 95 images, it started to endlessly try to load the next ones, without any result... |
nextcloud-android-bot
commented
Aug 17, 2019
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10424 |
nextcloud-android-bot
commented
Aug 17, 2019
Codacy276Lint
SpotBugs (new)
SpotBugs (master)
|
ezaquarii
commented
Aug 17, 2019
@mlaverdiere do you have the crash stacktrace? |
mlaverdiere
commented
Aug 17, 2019
Sorry, but how could I get the stacktrace? (just a regular user here, so I need some guidance...) 10424.apk loads pictures very fast, without any crash (so far), but again, stops after the first 95 images (endless spinning wheel) |
ezaquarii
commented
Aug 17, 2019
@mlaverdiere I'd expect you get a stacktrace displayed in a popup upon crash. It looks like this PR is behind master. I created another test build for you. This one should display the stack trace popup on crash: #4339 |
mlaverdiere
commented
Aug 17, 2019
OK, i just tested the 10427 build: no crash to report yet, but still stops after 95 pictures... |
gessel
commented
Jul 9, 2020
as #1682 and #6138 are closed and redirect here: Photos pane in android app isn't working; I switched from release to dev and tried with Nextcloud-android/20200707, it seems to time out and eventually (after 30-60 seconds or so) gives the No Photos/Upload some photos or activate auto upload. The Photos App on the server works as expected (and there are definitely photos). Model: SM-N950N |
svenb1234
commented
Jul 9, 2020
Same here with NC 18.0.6 and a Pixel 3a with the current Nextcloud App 3.12.1. Usually it only took unjustifiable long before the pictures appears, now it always times out. It also seems to be not easy to debug the app for a user, such as logging its requests to the server or some debugging console as browsers have it for debugging websites. |
AndyScherzinger
commented
Jul 9, 2020
The dev and debug builds do ship such a log view (accessible via the settings screen within the app) while this a general logging view, not one just for network communication |
AndyScherzinger
commented
Jul 10, 2020
other than that this is a (merged) PR, so it would be best to create an issue since discussions in merged, old PRs are rather getting lost in the Github notification noise |


Fix#4235
Fix#1972
Fix#1682
Fix#1901
Once this is merged, revert: nextcloud/android-library#322
Stalled by:nextcloud/server#15029nextcloud/server#15048This first loads 3x display items and on each bottom reach loads the next bunch of images.
Due to limitation of webdav this is currently only working if search is sorted by date, so not working on file names (for (favorite) search).
BUGS:
TODOs
Signed-off-by: tobiasKaminsky tobias@kaminsky.me