Skip to content

Fix user info route - #21

Merged
AndyScherzinger merged 2 commits into
masterfrom
userInfoRouteUpdate
Oct 21, 2016
Merged

Fix user info route#21
AndyScherzinger merged 2 commits into
masterfrom
userInfoRouteUpdate

Conversation

@AndyScherzinger

@AndyScherzingerAndyScherzinger commented Oct 18, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Resolves#18

I`ll test drive this first. As described in #18 this is an important change since the legacy URL won't work anymore for Nextcloud 11+

cc @tobiasKaminsky

@AndyScherzingerAndyScherzinger added this to the NC Android lib 1.0.8 milestone Oct 18, 2016
@AndyScherzingerAndyScherzinger mentioned this pull request Oct 18, 2016
Closed
@AndyScherzinger

AndyScherzinger commented Oct 18, 2016

Copy link
Copy Markdown
MemberAuthor

I tested the changed route info and it works for my server (where the old URL worked) and for the demo account that has been given to us for the server where the login didn't work and now that one works too.

@tobiasKaminsky please review and merge 😃 🚀

@AndyScherzinger

AndyScherzinger commented Oct 19, 2016

Copy link
Copy Markdown
MemberAuthor

@tobiasKaminsky this will automatically be in your next beta release since I pushed it to the lib's beta branch

@AndyScherzingerAndyScherzinger mentioned this pull request Oct 19, 2016
Closed
@tobiasKaminsky

tobiasKaminsky commented Oct 19, 2016

Copy link
Copy Markdown
Member

👍

@tobiasKaminsky

tobiasKaminsky commented Oct 19, 2016

Copy link
Copy Markdown
Member

@AndyScherzinger we need a second 👍 here ;)

@AndyScherzinger

AndyScherzinger commented Oct 19, 2016

Copy link
Copy Markdown
MemberAuthor

👍

@AndyScherzinger

AndyScherzinger commented Oct 19, 2016

Copy link
Copy Markdown
MemberAuthor

@jancborchardt@LukasReschke can you please 👍 :)

@AndyScherzinger

AndyScherzinger commented Oct 19, 2016

Copy link
Copy Markdown
MemberAuthor

You can merge @tobiasKaminsky

@jancborchardt

jancborchardt commented Oct 19, 2016

Copy link
Copy Markdown
Member

Can’t say anything here ;D @LukasReschke maybe

@jancborchardt

jancborchardt commented Oct 19, 2016

Copy link
Copy Markdown
Member

@AndyScherzinger or do you mean to bypass the merging 2 +1s? I can add you both as admins for the android and android-library repos.

@jancborchardt

jancborchardt commented Oct 19, 2016

Copy link
Copy Markdown
Member

Ah, you already are. :)

@AndyScherzinger

AndyScherzinger commented Oct 19, 2016

Copy link
Copy Markdown
MemberAuthor

Bypass the 2 👍s

@AndyScherzinger

AndyScherzinger commented Oct 21, 2016

Copy link
Copy Markdown
MemberAuthor

Works as expected and beta feedback is also positive. So merging.

@AndyScherzinger
AndyScherzinger merged commit efbbb16 into masterOct 21, 2016
@AndyScherzinger
AndyScherzinger deleted the userInfoRouteUpdate branch October 21, 2016 20:22
@AndyScherzingerAndyScherzinger mentioned this pull request Oct 23, 2016
Closed
surinder-tsys added a commit to nextmcloud/android-library that referenced this pull request Mar 1, 2023
@surinder-tsys
Merge pull requestnextcloud#21from surinder-tsys/dependabot/github_…
fe8c752
…actions/cirrus-actions/rebase-1.7
Bump cirrus-actions/rebase from 1.5 to 1.7
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminskytobiasKaminskytobiasKaminsky approved these changes

Assignees

No one assigned

Labels

bughigh

Projects

None yet

Milestone

NC lib 1.0.8

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyScherzinger@tobiasKaminsky@jancborchardt