Beta by tobiasKaminsky · Pull Request #169 · nextcloud/android

tobiasKaminsky · 2016-07-28T19:24:13Z

Dummy PR

AndyScherzinger · 2016-07-28T20:02:33Z

Just being on my phone, did you also update the search provider for user and groups and also the document provider?

tobiasKaminsky · 2016-07-30T10:21:07Z

Yes, but you can test it of course to make sure everything is working.
I have tested it, but of course I could have overseen something

AndyScherzinger · 2016-07-30T10:48:11Z

Sure, will do. Most likely Monday or Tuesday. Don't have the time before that :(

AndyScherzinger · 2016-08-08T08:14:07Z


+ <uses-permission android:name="android.permission.READ_PHONE_STATE" />
+ <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
+


Isn't this now a double entry looking at lines 63/64?

Not double, but triple ;)
Thanks for the catch!

AndyScherzinger · 2016-10-12T16:46:43Z

 }
-
+
+ dexOptions {


Now the dex options are duplicated?! 0_o @tobiasKaminsky

AndyScherzinger · 2016-10-12T16:47:26Z

 public static long getUsableSpace(String accountName) {
- File savePath = new File(MainApp.getStoragePath());
- return savePath.getUsableSpace();
+ File savePath = Environment.getExternalStorageDirectory();


This is legacy and the removed code was the newer version

AndyScherzinger · 2016-10-12T16:47:42Z


 public static String getLogPath() {
- return MainApp.getStoragePath() + File.separator + MainApp.getDataFolder() + File.separator + "log";
+ return Environment.getExternalStorageDirectory() + File.separator + MainApp.getDataFolder() + File.separator + "log";


This is legacy and the removed code was the newer version (ExternalSD card)

AndyScherzinger · 2016-10-19T16:17:45Z

@tobiasKaminsky can you do another beta release? This would then automatically include nextcloud/android-library#21 :) So this could then be tested, works with the test account I got.

need to reblock merge to master

AndyScherzinger

review to block beta to be merged

AndyScherzinger · 2016-11-06T22:45:30Z

- <item>DELETE</item>
+ <item>LOCAL_BEHAVIOUR_FORGET</item>
+ <item>LOCAL_BEHAVIOUR_MOVE</item>
+ <item>LOCAL_BEHAVIOUR_DELETE</item>


Does this impact pre lollipop devices, since this is still used in the older preferences screen?

block

AndyScherzinger

blocking review, so it won't be accidentally merged to master

AndyScherzinger · 2017-02-05T23:34:09Z

-[13 / 13] Master (nextcloud/master) [https://github.com/nextcloud/android] merged successfully
+2017-02-06
+Branches: 12
+[01 / 12] Rewrite auto upload (nextcloud/rewrite-auto-upload) [https://github.com/nextcloud/android/pull/615] CONFLICT


@mario to get some feedback, can you try to manually merge (and resolving conflicts) this into the beta branch? That way we can probably get some feedback :)

This reverts commit ab901a6.

commit ada7a6b Author: Mario Danic <mario@lovelyhq.com> Date: Mon Feb 6 02:13:20 2017 +0100 Attempt to fix HDR issues commit 2d3ee4f Author: Mario Danic <mario@lovelyhq.com> Date: Mon Feb 6 01:49:43 2017 +0100 Optimize imports commit bb08dc7 Author: Mario Danic <mario@lovelyhq.com> Date: Mon Feb 6 01:46:08 2017 +0100 Fix persistance commit 93b7899 Author: Mario Danic <mario@lovelyhq.com> Date: Mon Feb 6 01:30:19 2017 +0100 Revert "Use different models" This reverts commit ab901a6. commit ab901a6 Author: Mario Danic <mario@lovelyhq.com> Date: Mon Feb 6 01:25:04 2017 +0100 Use different models commit 18fc3bb Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 23:54:03 2017 +0100 Fix a serialization bug commit ff641bf Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 23:15:36 2017 +0100 Create new file commit 63259a1 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 23:13:55 2017 +0100 Fix a bug commit 21aa2ea Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 22:59:09 2017 +0100 Revert "Remove useless conditions" This reverts commit 5dd6d91. commit 9b37348 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 22:56:51 2017 +0100 Remove useless conditions commit 4de7261 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 22:52:50 2017 +0100 Magical magical stuff commit c73b8df Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 22:02:24 2017 +0100 Fix a typo with tmp files commit 98b4422 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 22:01:45 2017 +0100 Progress on implementing persistance commit 0eba0c3 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 10:19:55 2017 +0100 Add persistence layer on service start commit 870b6bb Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 05:02:23 2017 +0100 Move to approach without reflection commit 39228a0 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 03:22:48 2017 +0100 Preparation for persistance commit d74da82 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 01:23:39 2017 +0100 First step towards list persistance commit dbf1c09 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 00:18:47 2017 +0100 Ignore temporary files commit 21fee81 Author: Mario Danic <mario@lovelyhq.com> Date: Sun Feb 5 00:07:10 2017 +0100 Fix a bug with SyncedFolderProvider commit c0dc9fb Author: Mario Danic <mario@lovelyhq.com> Date: Sat Feb 4 23:28:33 2017 +0100 Small bugfix commit 75b4703 Author: Mario Danic <mario@lovelyhq.com> Date: Fri Feb 3 11:38:40 2017 +0100 Update copyrights commit 77f42fd Author: Mario Danic <mario@lovelyhq.com> Date: Fri Feb 3 11:35:04 2017 +0100 Remove strange <p> stuff commit a1371bd Author: Mario Danic <mario@lovelyhq.com> Date: Fri Feb 3 01:57:14 2017 +0100 Silence codacy commit 7b0154d Author: Mario Danic <mario@lovelyhq.com> Date: Fri Feb 3 00:23:06 2017 +0100 Enable menu item on 5.0 commit 6204c7e Author: Mario Danic <mario@lovelyhq.com> Date: Fri Feb 3 00:10:06 2017 +0100 Update a comment commit 77d6b64 Author: Mario Danic <mario@lovelyhq.com> Date: Fri Feb 3 00:07:15 2017 +0100 Revert a typo commit 4d25169 Author: Mario Danic <mario@lovelyhq.com> Date: Fri Feb 3 00:03:37 2017 +0100 Introduce rewritten auto upload

…lindness

….01.17 and upload it via autoupload on 10.02.17 it will be uploaded to Camera/2017/01

tobiasKaminsky · 2017-02-13T09:15:53Z

Closing as this drives Codacy crazy ;-)

tobiasKaminsky · 2017-02-13T09:16:13Z

Do NOT remove beta branch!

tobiasKaminsky added the dev version label Jul 28, 2016

AndyScherzinger reviewed Aug 8, 2016
View reviewed changes

This was referenced Aug 30, 2016
Update Toolchain/Android-Target to v24 #214
Merged
bugfix for empty folder display #229
Merged
Display quota if configured/available in navigation drawer #204
Merged

AndyScherzinger previously approved these changes Sep 22, 2016
View reviewed changes

AndyScherzinger reviewed Oct 12, 2016
View reviewed changes

AndyScherzinger requested changes Oct 26, 2016
View reviewed changes

AndyScherzinger reviewed Nov 6, 2016
View reviewed changes

AndyScherzinger assigned AndyScherzinger and tobiasKaminsky Nov 22, 2016

AndyScherzinger previously approved these changes Nov 22, 2016
View reviewed changes

AndyScherzinger requested changes Nov 23, 2016
View reviewed changes

AndyScherzinger reviewed Feb 5, 2017
View reviewed changes

tobiasKaminskyand others added 8 commits February 6, 2017 00:38

update to 20170206
0b7be2c

Use different models
ab901a6

Revert "Use different models"
93b7899
This reverts commit ab901a6.

Fix persistance
bb08dc7

Optimize imports
2d3ee4f

Attempt to fix HDR issues
ada7a6b

Fix to aid in HDR stuff processing
dcf99f8

AndyScherzingerand others added 27 commits February 12, 2017 21:12

new sorting order dialog
f18afe5

add breaks and empty default to switch
73f0e3b

default to alphabetical ascending
15f18b7

wired the new sorting order fragment
22d258d

minor tweaking and fixes for ordering
c8a01d2

change icons according to review
dd3f604

integrate new sorting dialog into Upload file activity
6cd6324

remove PreferenceManager dependency and work on input parameters only
2ec906f

move image button icon coloring to DisplayUtils
70ead72

flip arrow according to design review
485634a

redesign of dialog according to design review/mock/feedback
65d785c

slightly shorten code
fb43577

make actual selection bold, for easier recognition in case of color b…
1ef3550
…lindness

Merge remote-tracking branch 'carstendev/rotation-crash-fix' into beta
d1c081a

Merge remote-tracking branch 'nextcloud/newSortingLayout' into beta
811e95c

daily beta build
3f58517

update to 20170213
9975de9

Simplify new auto upload code
0754e93

Merge branch 'rewrite-auto-upload' into beta
0276dc1

Merge remote-tracking branch 'nextcloud/master' into beta
600260e

daily beta build
aee15bb

update to 20170213
ce8d87a

user last modification date for auto upload, e.g. take an image on 31…
d86e673
….01.17 and upload it via autoupload on 10.02.17 it will be uploaded to Camera/2017/01

New build
0d35a38

Merge branch 'rewrite-auto-upload' into beta
74a307c

daily beta build
80069bb

update to 20170213
9ec2827

tobiasKaminsky closed this Feb 13, 2017


		<uses-permission android:name="android.permission.READ_PHONE_STATE" />
		<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />

Uh oh!

Uh oh!

Conversation

tobiasKaminsky commented Jul 28, 2016

Uh oh!

AndyScherzinger commented Jul 28, 2016

Uh oh!

tobiasKaminsky commented Jul 30, 2016

Uh oh!

AndyScherzinger commented Jul 30, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger commented Oct 19, 2016

Uh oh!

AndyScherzinger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tobiasKaminsky commented Feb 13, 2017

Uh oh!

tobiasKaminsky commented Feb 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants