Skip to content

public sharing: ask for password - #294

Merged
AndyScherzinger merged 1 commit into
masterfrom
askForPassword
May 10, 2019
Merged

public sharing: ask for password#294
AndyScherzinger merged 1 commit into
masterfrom
askForPassword

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

Needed for nextcloud/android#3989

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings42
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings22
Security Warnings17
Dodgy code Warnings84
Total195

FindBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings42
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings22
Security Warnings17
Dodgy code Warnings84
Total195

@codecov

codecovBot commented May 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #294 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #294 +/- ##
==========================================
- Coverage 18% 17.97% -0.03% 
==========================================
Files 121 121 Lines 5266 5273 +7 Branches 722 723 +1 ==========================================
Hits 948 948 - Misses 4183 4190 +7 
Partials 135 135
Impacted FilesCoverage Δ
...oud/android/lib/resources/status/OCCapability.java0% <0%> (ø)⬆️
...sources/status/GetRemoteCapabilitiesOperation.java0% <0%> (ø)⬆️

@AndyScherzinger
AndyScherzinger merged commit 7b8b392 into masterMay 10, 2019
@AndyScherzinger
AndyScherzinger deleted the askForPassword branch May 10, 2019 20:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasKaminsky@nextcloud-android-bot@AndyScherzinger