Public share: if ask for password is set, show an optional password dialog

[tobiasKaminsky]

Ref:

• add "askForPassword" on capabilities for sharing server#15461

This is a new capability, starting with NC17.
As the current behaviour is to not show any dialog, it is ok to add it right now.
If the flag is set (see below), then it will be used.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[tobiasKaminsky]

Will wait for final decision on capability name.

[codecov]

Codecov Report

Merging #3989 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #3989 +/- ##
===========================================
- Coverage 6.61% 6.57% -0.04% 
Complexity 1 1 ===========================================
Files 326 322 -4 Lines 30930 30946 +16 Branches 4409 4412 +3 ===========================================
- Hits 2045 2036 -9 - Misses 28588 28615 +27 + Partials 297 295 -2

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	84.61% <ø> (ø)	0 <0> (ø)	⬇️
...android/ui/dialog/SharePasswordDialogFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	11.92% <0%> (-0.04%)	0 <0> (ø)
...om/owncloud/android/ui/activity/ShareActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...om/owncloud/android/ui/dialog/SendShareDialog.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/providers/FileContentProvider.java	19.13% <0%> (-0.23%)	0 <0> (ø)
...android/ui/fragment/FileDetailSharingFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...cloud/android/ui/activity/FileDisplayActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/ui/fragment/ShareFileFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...cloud/android/ui/helpers/FileOperationsHelper.java	0% <0%> (ø)	0 <0> (ø)	⬇️
... and 17 more

[codecov]

Codecov Report

Merging #3989 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #3989 +/- ##
===========================================
- Coverage 6.7% 6.68% -0.02% 
Complexity 1 1 ===========================================
Files 326 326 Lines 30884 30915 +31 Branches 4406 4409 +3 ===========================================
- Hits 2070 2068 -2 - Misses 28516 28547 +31 - Partials 298 300 +2

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	84.61% <ø> (ø)	0 <0> (ø)	⬇️
...android/ui/dialog/SharePasswordDialogFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	11.85% <0%> (-0.05%)	0 <0> (ø)
...om/owncloud/android/ui/activity/ShareActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...om/owncloud/android/ui/dialog/SendShareDialog.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/providers/FileContentProvider.java	18.91% <0%> (-0.22%)	0 <0> (ø)
...android/ui/fragment/FileDetailSharingFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...cloud/android/ui/activity/FileDisplayActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/ui/fragment/ShareFileFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...cloud/android/ui/helpers/FileOperationsHelper.java	0% <0%> (ø)	0 <0> (ø)	⬇️
... and 1 more

[nextcloud-android-bot]

Codacy

279

Lint

Type	master	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	174
Security Warnings	47
Dodgy code Warnings	140
Total	490

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	174
Security Warnings	47
Dodgy code Warnings	141
Total	491

Android-library is not set to master branch in build.gradle

[AndyScherzinger]

@tobiasKaminsky needs another rebase to resolve latest conflicts

[nextcloud-android-bot]

Codacy

284

Lint

Type	master	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	122
Security Warnings	47
Dodgy code Warnings	140
Total	438

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	122
Security Warnings	47
Dodgy code Warnings	140
Total	438

[nextcloud-android-bot]

Codacy

284

Lint

Type	master	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	122
Security Warnings	47
Dodgy code Warnings	140
Total	438

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	122
Security Warnings	47
Dodgy code Warnings	140
Total	438