Uh oh!
There was an error while loading. Please reload this page.
Add RichWorkspaces support - #360
Merged
Merged
Conversation
tobiasKaminskyforce-pushed
the
directEditing
branch
5 times, most recently
from
December 10, 2019 09:29
fba5598 to
04cb1c1ComparetobiasKaminskyforce-pushed
the
directEditing
branch
2 times, most recently
from
December 16, 2019 11:48
b3ae955 to
6a639eaComparetobiasKaminskyforce-pushed
the
richWorkspace
branch
from
December 16, 2019 12:35
e6f5c3f to
21869b5ComparetobiasKaminskyforce-pushed
the
directEditing
branch
from
December 17, 2019 07:19
ff291a9 to
1c603f3ComparetobiasKaminskyforce-pushed
the
richWorkspace
branch
from
December 17, 2019 11:09
0f40c49 to
edcb24aComparetobiasKaminskyforce-pushed
the
richWorkspace
branch
2 times, most recently
from
December 17, 2019 11:12
3d8dbd4 to
f9922c3CompareSigned-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminskyforce-pushed
the
richWorkspace
branch
from
December 17, 2019 13:17
f9922c3 to
367ed98Comparenextcloud-android-bot
commented
Dec 17, 2019
Collaborator
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1361 |
nextcloud-android-bot
commented
Dec 18, 2019
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
nextcloud-android-bot
commented
Dec 18, 2019
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@## master #360 +/- ##
========================================
Coverage ? 34.3% ========================================
Files ? 133 Lines ? 5728 Branches ? 751 ========================================
Hits ? 1965 Misses ? 3487 Partials ? 276
|
| private String path; | ||
| public RichWorkspaceDirectEditingRemoteOperation(String path) { |
There was a problem hiding this comment.
could be created via lombok
AndyScherzinger
previously approved these changes
Dec 18, 2019
AndyScherzinger
left a comment
Member
There was a problem hiding this comment.
looks good, just one minor comment
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
nextcloud-android-bot
commented
Dec 18, 2019
Collaborator
Complexity increasing per file
==============================
- src/androidTest/java/com/nextcloud/android/lib/richWorkspace/RichWorkspaceDirectEditingRemoteOperationTest.java 1- src/main/java/com/nextcloud/android/lib/richWorkspace/RichWorkspaceDirectEditingRemoteOperation.java 4
Clones added
============
- src/main/java/com/nextcloud/android/lib/richWorkspace/RichWorkspaceDirectEditingRemoteOperation.java 1See the complete overview on Codacy |
nextcloud-android-bot
commented
Dec 18, 2019
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #358
Signed-off-by: tobiasKaminsky tobias@kaminsky.me