Add direct endpoint api by tobiasKaminsky · Pull Request #358 · nextcloud/android-library

tobiasKaminsky · 2019-11-26T09:51:27Z

revert to master, once Direct editing text#372 is merged
write more tests for capability

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

AndyScherzinger · 2019-12-09T11:22:07Z

+ private String filePath;
+ private String editor;
+
+ public DirectEditingOpenFileRemoteOperation(String filePath, String editor) {


AndyScherzinger · 2019-12-09T11:23:42Z

@tobiasKaminsky looks good to me. Just some minor comments about further utilization of lombok 👍

AndyScherzinger · 2019-12-10T16:01:07Z

Looks good to me 👍

tobiasKaminsky · 2019-12-11T10:18:44Z

Tests fails as @juliushaertl seems to removed the templates.
Will the remain removed?

nextcloud-android-bot · 2019-12-12T08:46:55Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	15
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	52
Total	136

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	15
Correctness Warnings	37
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	58
Total	160

nextcloud-android-bot · 2019-12-16T13:02:20Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1346

nextcloud-android-bot · 2019-12-16T13:29:05Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	57
Total	144

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	41
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	63
Total	168

SpotBugs increased!

nextcloud-android-bot · 2019-12-16T15:36:17Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1347

nextcloud-android-bot · 2019-12-16T15:59:18Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	57
Total	144

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	41
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	63
Total	168

SpotBugs increased!

nextcloud-android-bot · 2019-12-16T18:02:21Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1348

nextcloud-android-bot · 2019-12-16T18:28:34Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	57
Total	144

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	41
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	63
Total	168

SpotBugs increased!

nextcloud-android-bot · 2019-12-17T06:50:14Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	57
Total	144

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	41
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	63
Total	168

SpotBugs increased!

AndyScherzinger · 2019-12-17T07:13:39Z

@tobiasKaminsky Spotbugs is drunk...

tobiasKaminsky · 2019-12-17T07:14:42Z

Hehe. Somehow yes…I will change it accordingly, once all tests are green.
(then also rebase it)

nextcloud-android-bot · 2019-12-17T07:15:29Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1351

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

nextcloud-android-bot · 2019-12-17T07:22:08Z

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/lib/common/TemplateList.java 1- src/main/java/com/owncloud/android/lib/resources/status/GetCapabilitiesRemoteOperation.java 1- src/androidTest/java/com/nextcloud/android/lib/resources/directediting/DirectEditingOpenFileRemoteOperationTest.java 1- src/androidTest/java/com/nextcloud/android/lib/resources/directediting/DirectEditingObtainListOfTemplatesRemoteOperationTest.java 1- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingCreateFileRemoteOperation.java 5- src/androidTest/java/com/nextcloud/android/lib/resources/directediting/DirectEditingCreateFileRemoteOperationTest.java 1- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingObtainListOfTemplatesRemoteOperation.java 4- src/main/java/com/owncloud/android/lib/common/Creator.java 3- src/androidTest/java/com/nextcloud/android/lib/resources/directediting/DirectEditingObtainRemoteOperationTest.java 1- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingObtainRemoteOperation.java 4- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingOpenFileRemoteOperation.java 4
Clones added
============
- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingCreateFileRemoteOperation.java 1- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingOpenFileRemoteOperation.java 1

See the complete overview on Codacy

nextcloud-android-bot · 2019-12-17T07:25:23Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1353

nextcloud-android-bot · 2019-12-17T07:32:20Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1354

nextcloud-android-bot · 2019-12-17T07:43:42Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	57
Total	144

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	41
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	63
Total	168

SpotBugs increased!

nextcloud-android-bot · 2019-12-17T07:56:22Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	57
Total	144

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	41
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	63
Total	168

nextcloud-android-bot · 2019-12-17T08:03:50Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1355

nextcloud-android-bot · 2019-12-17T08:22:39Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	57
Total	144

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	41
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	63
Total	168

nextcloud-android-bot · 2019-12-17T10:56:54Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1356

tobiasKaminsky · 2019-12-17T11:04:50Z

Last failing test will be resolved via nextcloud/text#478

nextcloud-android-bot · 2019-12-17T11:34:25Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	1
Dodgy code Warnings	57
Total	144

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	41
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	63
Total	168

tobiasKaminsky added 3. to review 2. developing and removed 3. to review labels Nov 26, 2019

tobiasKaminsky force-pushed the directEditing branch from fd06ee2 to 0b89600Compare November 26, 2019 12:20

tobiasKaminsky mentioned this pull request Nov 28, 2019
Add RichWorkspaces support #360
Merged

tobiasKaminsky force-pushed the directEditing branch from beeb7ec to f28477fCompare December 5, 2019 07:28

tobiasKaminsky added 3. to review and removed 2. developing labels Dec 5, 2019

nextcloud deleted a comment from nextcloud-android-bot Dec 5, 2019

tobiasKaminsky requested a review from AndyScherzinger December 9, 2019 11:10