Skip to content

Start using the previews from the server - #1421

Closed
nickvergessen wants to merge 1 commit into
masterfrom
activity-previews-from-server
Closed

Start using the previews from the server#1421
nickvergessen wants to merge 1 commit into
masterfrom
activity-previews-from-server

Conversation

@nickvergessen

@nickvergessennickvergessen commented Aug 24, 2017

Copy link
Copy Markdown
Member
  • API should return the mimetype as well, so the clients can use their local mimetype icons if available
  • API should return path + id so apps can link to the file locally instead of redirecting to the browser
  • Readd onClick handler (local when available otherwise browser (trashbin))
  • Kill setBitmap after local mimetype icons are used

@nickvergessennickvergessen added this to the Nextcloud App 2.1.0 milestone Aug 24, 2017
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch 4 times, most recently from 7959d7b to 10e375cCompareOctober 20, 2017 18:36
@tobiasKaminsky

Copy link
Copy Markdown
Member

@nickvergessen do we want to finish this during hackweek (we/thu)?

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

I dont think I got time

@AndyScherzingerAndyScherzinger modified the milestones: Nextcloud App 2.1.0, Nextcloud App 2.2.0Nov 9, 2017
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch from 10e375c to f102a39CompareNovember 9, 2017 13:07
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch 2 times, most recently from d649558 to 9d1bcb2CompareJanuary 25, 2018 16:05
@nextcloudnextcloud deleted a comment Jan 25, 2018
@nextcloudnextcloud deleted a comment Jan 25, 2018
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch from 9d1bcb2 to 375ab91CompareJanuary 29, 2018 08:25
@nextcloudnextcloud deleted a comment Jan 29, 2018
@nextcloudnextcloud deleted a comment Jan 29, 2018
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch from 375ab91 to a56703fCompareJanuary 31, 2018 09:58
@nextcloudnextcloud deleted a comment Jan 31, 2018
@nextcloudnextcloud deleted a comment Jan 31, 2018
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch from a56703f to 927c487CompareFebruary 6, 2018 11:29
@nextcloudnextcloud deleted a comment Feb 6, 2018
@nextcloudnextcloud deleted a comment Feb 6, 2018
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch from 927c487 to 37e0047CompareFebruary 7, 2018 17:43
@nextcloudnextcloud deleted a comment Feb 7, 2018
@nextcloudnextcloud deleted a comment Feb 7, 2018
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch from a41948d to 9e6b51bCompareMarch 12, 2018 17:34
@nextcloudnextcloud deleted a comment Mar 12, 2018
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch from 9e6b51b to 130b488CompareMarch 15, 2018 09:23
@nextcloudnextcloud deleted a comment Mar 15, 2018
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch 5 times, most recently from 073437b to d571cc2CompareMay 27, 2018 20:50
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch 3 times, most recently from 8053f0d to 85acc76CompareJune 4, 2018 13:18
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch 7 times, most recently from 418df1b to a0fee02CompareJune 12, 2018 14:26
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch 6 times, most recently from d80c2f4 to 11e4a02CompareJune 24, 2018 09:10
Signed-off-by: Joas Schilling <coding@schilljs.com>
@AndyScherzinger
AndyScherzingerforce-pushed the activity-previews-from-server branch from 11e4a02 to d1c8c0eCompareJune 27, 2018 12:55
@tobiasKaminsky

Copy link
Copy Markdown
Member

@nickvergessen once the activity API returns mentioned parts (mimetype, fileId, …) please re-open or create an issue, so that we can develop this.
Keeping this old PR just causes overhead while trying to keep it up to date.

@tobiasKaminsky
tobiasKaminsky deleted the activity-previews-from-server branch December 10, 2018 08:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@tobiasKaminsky@AndyScherzinger