Add activity previews

[nickvergessen]

Tobi: this adds support for using preview url instead of generating the thumbnails locally.

Implementation on client side: nextcloud/android#3130

Needs: nextcloud/activity#300

[tobiasKaminsky]

So this should work now, please feel free to ask me on irc at any time

[tobiasKaminsky]

Quick reminder: we need to pass the desired height/width to it, otherwise we will download a too big/too blurry image.

[mario]

Do we merge this or what

[AndyScherzinger]

Quick reminder: we need to pass the desired height/width to it, otherwise we will download a too big/too blurry image.

@tobiasKaminsky is this issue resolved?

[tobiasKaminsky]

@nickvergessen what is the status here?
If it is not yet finished, do we want to have a look into it on xmas hacking?

Edit: Talked to joas. As he will soon be on vacation I will have look into it.

[tobiasKaminsky]

I fear that I need to talk to Joas to understand what the benefit of this is -> postponing.

[nextcloud-android-bot]

Lint

Type	Master	PR
Warnings	0	0
Errors	0	0

FindBugs (new)

Warning Type	Number
Bad practice Warnings	11
Correctness Warnings	42
Internationalization Warnings	5
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	3
Performance Warnings	18
Security Warnings	28
Dodgy code Warnings	85
Total	201

FindBugs (master)

Warning Type	Number
Bad practice Warnings	11
Correctness Warnings	42
Internationalization Warnings	5
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	3
Performance Warnings	18
Security Warnings	28
Dodgy code Warnings	84
Total	200

[tobiasKaminsky]

This one is backward compatible.
Tested on NC14

[tobiasKaminsky]

Quick reminder: we need to pass the desired height/width to it, otherwise we will download a too big/too blurry image.

@nickvergessen currently this seems to be hardcoded to 150x150 px.
Is there a way that we can pass a desired height/width?

[nickvergessen]

I guess instead of a bool for preview we could make it also an integer and pipe the size through until:
https://github.com/nextcloud/activity/pull/300/files#diff-9dabc5ebf438ea378e7ca813d2ba0f19L390

[nickvergessen]

Feel free to open an issue in the activity app if that's an issue. But wont happen before 15.0.1

[tobiasKaminsky]

Thanks for pointing out how to do this.
I created an issue.

Once this is implemented, I can develop it for android, but this should not prevent this PR from merging :-)

[AndyScherzinger]

👍

[mario]

👍