Activity: use image url instead of generating previews by oneself

[tobiasKaminsky]

Needs nextcloud/android-library#73 and nextcloud/activity#300

Previously we tried to find a referenced file in our database and then generated a thumbnail out of it.
Now we rely on the server to get a preview url. This way we can have thumbnails for files we never had in our database before.

TODO

• add backwards compatibility

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[tobiasKaminsky]

Damn, I totally forgot the backward compatibility :-/

[AndyScherzinger]

@tobiasKaminsky the lib change say compatible with Nc14. Is that what you meant with backwards compatible, because there is still also Nc13 maybe 12?

[tobiasKaminsky]

I am using old thumbnail system on <15 and new on >=15:
https://github.com/nextcloud/android/pull/3130/files#diff-521d2e61330253bb0889bddc78c08d0dR204

It depends on activity app version, but I would like to bind it to a NC version, so that we can remove it on NC19 :-)

[AndyScherzinger]

👍

[mario]

👍

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	83	83
Errors	0	0

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	159
Internationalization Warnings	15
Malicious code vulnerability Warnings	11
Multithreaded correctness Warnings	9
Performance Warnings	121
Security Warnings	66
Dodgy code Warnings	134
Total	550

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	159
Internationalization Warnings	15
Malicious code vulnerability Warnings	11
Multithreaded correctness Warnings	9
Performance Warnings	121
Security Warnings	66
Dodgy code Warnings	135
Total	551

[AndyScherzinger]

@tobiasKaminsky fancy taking a look? I am on the train right now so I can't :/

EDIT: drone was just using the old lib, though it was changed in branch…

[tobiasKaminsky]

What shall I do? I merged it ~45min before your comment :-)

[AndyScherzinger]

Nothing all. Good it seems.