Skip to content

Re-add content search type - #4233

Closed
tobiasKaminsky wants to merge 1 commit into
masterfrom
contentSearchType
Closed

Re-add content search type#4233
tobiasKaminsky wants to merge 1 commit into
masterfrom
contentSearchType

Conversation

@tobiasKaminsky

@tobiasKaminskytobiasKaminsky commented Jul 15, 2019

Copy link
Copy Markdown
Member

Depends on nextcloud/android-library#319

❗ Stalled by nextcloud/android-library#319
Should be based upon photoSearchLimit branch.

Comment threadsrc/main/java/com/owncloud/android/ui/EmptyRecyclerView.java
Comment threadsrc/main/java/com/owncloud/android/ui/activity/DrawerActivity.java Outdated
Comment threadsrc/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java Outdated
Comment threadsrc/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java Outdated
Comment threadsrc/main/java/com/owncloud/android/ui/fragment/PhotoFragment.java Outdated
Comment threadsrc/main/java/com/owncloud/android/ui/fragment/PhotoFragment.java Outdated
Comment threadsrc/main/java/com/owncloud/android/ui/fragment/PhotoFragment.java Outdated
Comment threadsrc/main/java/com/owncloud/android/ui/fragment/PhotoFragment.java Outdated
@ezaquarii

ezaquarii commented Jul 20, 2019

Copy link
Copy Markdown
Collaborator

This is completely new fragment and I believe we could greatly benefit from using ViewModel here. View models greatly improve testability.

@tobiasKaminsky

Copy link
Copy Markdown
MemberAuthor

@ezaquarii I messed something up. I wanted to split up #2250 so that #2250 does not contain any "content search type".
Now it seems that both PRs have the same changes to master and so your comments need to be in #2250.
I'll check them and change them in #2250 and after that try to rebase this PR to be ontop of #2250, also changing the base branch here in github.

@tobiasKaminsky

Copy link
Copy Markdown
MemberAuthor

This is completely new fragment and I believe we could greatly benefit from using ViewModel here. View models greatly improve testability.

While this is a new fragment, it is "only" a subset of OCFileListFragemnt, which is a subclass of ExtendedListFragment.

Indeed, we should change this, but please not in this PR.

@tobiasKaminsky

Copy link
Copy Markdown
MemberAuthor

All further discussion should go in #2250 as this PR will be based on it.

@tobiasKaminsky
tobiasKaminskyforce-pushed the contentSearchType branch 2 times, most recently from c16bc44 to c311a70CompareJuly 30, 2019 09:29
@tobiasKaminsky
tobiasKaminsky changed the base branch from master to photoSearchLimitJuly 30, 2019 09:30
@tobiasKaminsky
tobiasKaminskyforce-pushed the photoSearchLimit branch 3 times, most recently from 46fdd57 to 3d9126aCompareAugust 16, 2019 06:45
@tobiasKaminsky
tobiasKaminsky changed the base branch from photoSearchLimit to masterOctober 29, 2019 07:42
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11453.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Codacy

299

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

@codecov

codecovBot commented Oct 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4233 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #4233 +/- ##
============================================
- Coverage 17.45% 17.44% -0.02% 
Complexity 3 3 ============================================
Files 376 376 Lines 32309 32314 +5 Branches 4560 4561 +1 ============================================
- Hits 5640 5636 -4 - Misses 25765 25772 +7 - Partials 904 906 +2
Impacted FilesCoverage ΔComplexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java0% <ø> (ø)0 <0> (ø)⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java25.5% <0%> (-0.48%)0 <0> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java44.53% <0%> (-0.21%)0 <0> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java22.79% <0%> (-0.57%)0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java20.25% <0%> (+0.08%)0% <0%> (ø)⬇️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky@ezaquarii@nextcloud-android-bot@AndyScherzinger