Uh oh!
There was an error while loading. Please reload this page.
Re-add content search type - #4233
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This is completely new fragment and I believe we could greatly benefit from using |
tobiasKaminsky
commented
Jul 30, 2019
@ezaquarii I messed something up. I wanted to split up #2250 so that #2250 does not contain any "content search type". |
tobiasKaminsky
commented
Jul 30, 2019
While this is a new fragment, it is "only" a subset of OCFileListFragemnt, which is a subclass of ExtendedListFragment. Indeed, we should change this, but please not in this PR. |
tobiasKaminsky
commented
Jul 30, 2019
All further discussion should go in #2250 as this PR will be based on it. |
c16bc44 to
c311a70Compare46fdd57 to
3d9126aComparec311a70 to
e22543bCompareSigned-off-by: tobiasKaminsky <tobias@kaminsky.me>
e22543b to
b111182Comparenextcloud-android-bot
commented
Oct 29, 2019
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11453.apk |
nextcloud-android-bot
commented
Oct 29, 2019
Codacy299Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@## master #4233 +/- ##
============================================
- Coverage 17.45% 17.44% -0.02%
Complexity 3 3 ============================================
Files 376 376 Lines 32309 32314 +5 Branches 4560 4561 +1 ============================================
- Hits 5640 5636 -4 - Misses 25765 25772 +7 - Partials 904 906 +2
|

Depends on nextcloud/android-library#319
❗ Stalled by nextcloud/android-library#319 ❗
Should be based upon photoSearchLimit branch.