Skip to content

[DO NOT MERGE] Ezaquarii/photo search limit - #4339

Closed
ezaquarii wants to merge 2 commits into
masterfrom
ezaquarii/photoSearchLimit
Closed

[DO NOT MERGE] Ezaquarii/photo search limit#4339
ezaquarii wants to merge 2 commits into
masterfrom
ezaquarii/photoSearchLimit

Conversation

@ezaquarii

Copy link
Copy Markdown
Collaborator

This is temporary build allowing user to capture stack trace. Please do not merge.

tobiasKaminskyand others added 2 commits August 16, 2019 08:45
- cache query for 30s
- show progressbar if loading more
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10427.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@codecov

codecovBot commented Aug 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4339 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #4339 +/- ##
=========================================
Coverage 17.94% 17.94% Complexity 1 1 =========================================
Files 356 356 Lines 33339 33339 Branches 5022 5022 =========================================
Hits 5984 5984 Misses 26351 26351 Partials 1004 1004

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Codacy

276

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings111
Security Warnings46
Dodgy code Warnings138
Total413

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings111
Security Warnings46
Dodgy code Warnings135
Total410

@ezaquariiezaquarii mentioned this pull request Aug 17, 2019
11 tasks
@tobiasKaminsky

Copy link
Copy Markdown
Member

This is temporary build allowing user to capture stack trace. Please do not merge.

You "only" merged master into the branch. If this is the only thing, you can also do a rebase on #2250 and leave a comment.

@tobiasKaminsky

Copy link
Copy Markdown
Member

Closing as the base PR is merged.

@AndyScherzinger
AndyScherzinger deleted the ezaquarii/photoSearchLimit branch August 20, 2019 08:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ezaquarii@nextcloud-android-bot@tobiasKaminsky