Uh oh!
There was an error while loading. Please reload this page.
Change pdf icon - #5796
Merged
Merged
Conversation
I heard you liked changelogs, so I put a changelog in your changelog... or something. How meta. Signed-off-by: AJ Jordan <alex@strugee.net>
tobiasKaminsky
commented
Apr 2, 2020
MemberAuthor
/backport to stable-3.11 |
AndyScherzinger
approved these changes
Apr 2, 2020
nextcloud-android-bot
commented
Apr 2, 2020
Collaborator
Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13377-Screenshot |
AndyScherzinger
commented
Apr 2, 2020
Member
@tobiasKaminsky lint needs to be bumped +2, else looks fine! While I'd guess this doesn't need to be auto mirrored (no?) |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Ignore CHANGELOG.md while generating changelogs
…ip ci] Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
nextcloud-android-bot
commented
Apr 8, 2020
Collaborator
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13448.apk |
nextcloud-android-bot
commented
Apr 8, 2020
Collaborator
Codacy402Lint
SpotBugs (new)
SpotBugs (master)
|
The backport to stable-3.11 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nextcloud/server#20234
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests