Uh oh!
There was an error while loading. Please reload this page.
Remove Acrobat logo from PDF filetype icon - #20234
Merged
Merged
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
skjnldsv
commented
Mar 30, 2020
Member
It should looks ok as preview, we're using 32 there :) |
skjnldsv
approved these changes
Mar 30, 2020
juliusknorr
approved these changes
Mar 30, 2020
juliusknorr
commented
Mar 30, 2020
Member
/backport to stable18 |
juliusknorr
commented
Mar 30, 2020
Member
/backport to stable17 |
juliusknorr
commented
Mar 30, 2020
Member
/backport to stable16 |
backport to stable18 in #20238 |
backport to stable17 in #20239 |
backport to stable16 in #20240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Adobe PDF file icon guidelines are not really clear: https://www.adobe.com/legal/permissions/icons-web-logos.html#pdfs
But there’s a very similar question where there’s a clear answer: https://community.adobe.com/t5/acrobat/pdf-icon-use-legality/m-p/9883407?page=1#M103287
→ We shouldn’t use the Acrobat trefoil, even referring to PDF.
I did a version of the text document in red but it just didn’t look like PDF. Other platforms like Google Drive also use a similar solution with a red icon and "PDF" letters.
Please review @karlitschek@juliushaertl@skjnldsv – we should probably backport to whatever we still support. Also cc @marinofaggiana@tobiasKaminsky as we should also update that in the mobile apps.
(cc @skjnldsv I tried to pixel-align but it’s basically not possible on this small 16px grid while making it look good. It is sort-of aligned to 32px. Looking at it in the different sizes it seems nice.)