Skip to content

Query Param needs serial uid - #9261

Merged
tobiasKaminsky merged 1 commit into
masterfrom
fixSSO
Nov 15, 2021
Merged

Query Param needs serial uid#9261
tobiasKaminsky merged 1 commit into
masterfrom
fixSSO

Conversation

@tobiasKaminsky

@tobiasKaminskytobiasKaminsky commented Nov 14, 2021

Copy link
Copy Markdown
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky

Copy link
Copy Markdown
MemberAuthor

/backport to stable-3.18

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Codacy

Lint

TypemasterPR
Warnings109109
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 69
Security Warnings 40
Dodgy code Warnings 343
Total638

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 69
Security Warnings 40
Dodgy code Warnings 343
Total638

@github-actions

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9261.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions

Copy link
Copy Markdown

@codecov

codecovBot commented Nov 14, 2021

Copy link
Copy Markdown

Codecov Report

Merging #9261 (9751de3) into master (507f0ae) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #9261 +/- ##
==========================================
- Coverage 31.13% 31.06% -0.07% 
==========================================
Files 501 501 Lines 38228 38228 Branches 5286 5286 ==========================================
- Hits 11901 11876 -25 - Misses 24574 24597 +23 - Partials 1753 1755 +2 
Impacted FilesCoverage Δ
...ain/java/com/nextcloud/android/sso/QueryParam.java100.00% <ø> (ø)
...va/com/owncloud/android/utils/FilesSyncHelper.java14.60% <0.00%> (-6.75%)⬇️
...cloud/android/datamodel/UploadsStorageManager.java66.42% <0.00%> (-5.78%)⬇️
...ain/java/com/owncloud/android/db/UploadResult.java39.74% <0.00%> (-2.57%)⬇️
.../third_parties/daveKoeller/AlphanumComparator.java80.95% <0.00%> (-1.20%)⬇️
...wncloud/android/providers/FileContentProvider.java23.82% <0.00%> (-0.51%)⬇️
...ncloud/android/operations/UploadFileOperation.java60.39% <0.00%> (-0.50%)⬇️
...loud/android/datamodel/FileDataStorageManager.java56.94% <0.00%> (-0.24%)⬇️
.../owncloud/android/files/services/FileUploader.java48.28% <0.00%> (-0.21%)⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java44.57% <0.00%> (+0.33%)⬆️
... and 3 more

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasKaminsky@nextcloud-android-bot@stefan-niedermann