Skip to content

[stable-3.18] Query Param needs serial uid - #9271

Merged
AlvaroBrey merged 1 commit into
stable-3.18from
backport/9261/stable-3.18
Nov 15, 2021
Merged

[stable-3.18] Query Param needs serial uid#9271
AlvaroBrey merged 1 commit into
stable-3.18from
backport/9261/stable-3.18

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #9261

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9271.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

Typestable-3.18PR
Warnings109109
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings 28
Correctness Warnings 48
Internationalization Warnings 9
Malicious code vulnerability Warnings 51
Multithreaded correctness Warnings 9
Performance Warnings 65
Security Warnings 40
Dodgy code Warnings 101
Total351

SpotBugs (stable-3.18)

Warning TypeNumber
Bad practice Warnings 28
Correctness Warnings 48
Internationalization Warnings 9
Malicious code vulnerability Warnings 51
Multithreaded correctness Warnings 9
Performance Warnings 65
Security Warnings 40
Dodgy code Warnings 101
Total351

@github-actions

Copy link
Copy Markdown

@codecov

codecovBot commented Nov 15, 2021

Copy link
Copy Markdown

Codecov Report

Merging #9271 (b3aa901) into stable-3.18 (73c1c9e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## stable-3.18 #9271 +/- ##
============================================
Coverage 31.00% 31.01% ============================================
Files 501 501 Lines 38213 38213 Branches 5286 5286 ============================================
+ Hits 11849 11852 +3 + Misses 24609 24608 -1 + Partials 1755 1753 -2 
Impacted FilesCoverage Δ
...ain/java/com/nextcloud/android/sso/QueryParam.java100.00% <ø> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java82.14% <0.00%> (-1.20%)⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java78.15% <0.00%> (-0.69%)⬇️
...ncloud/android/operations/UploadFileOperation.java60.39% <0.00%> (-0.33%)⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java38.90% <0.00%> (-0.19%)⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java25.00% <0.00%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java24.75% <0.00%> (+0.08%)⬆️
...loud/android/datamodel/FileDataStorageManager.java57.17% <0.00%> (+0.23%)⬆️
.../java/com/owncloud/android/utils/DisplayUtils.java34.13% <0.00%> (+2.00%)⬆️

@AlvaroBrey
AlvaroBrey merged commit 68b814a into stable-3.18Nov 15, 2021
@AndyScherzinger
AndyScherzinger deleted the backport/9261/stable-3.18 branch November 19, 2021 08:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nextcloud-android-bot@stefan-niedermann@AlvaroBrey@tobiasKaminsky