Uh oh!
There was an error while loading. Please reload this page.
Update deprecated globals in 19 - #1950
Merged
Merged
Conversation
Ref nextcloud/server#19455 Ref nextcloud/server#19346 Ref nextcloud/server#15403 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
korelstar, marcelklehr, raimund-schluessler and skjnldsvApril 10, 2020 08:15
skjnldsv
approved these changes
Apr 10, 2020
korelstar
commented
Apr 10, 2020
Member
This should be added to https://github.com/nextcloud/eslint-plugin/blob/master/lib/rules/no-deprecations.js , too. |
ChristophWurst
commented
Apr 10, 2020
MemberAuthor
Yeah, on my todo for this afternoon already :) |
ChristophWurst
commented
Apr 10, 2020
MemberAuthor
Okay, let's say next week 🙏 |
raimund-schluessler added a commit
to nextcloud/tasks
that referenced
this pull request
Apr 10, 2020
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org> See nextcloud/documentation#1950
ChristophWurst
commented
Apr 14, 2020
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/server#19455
Ref nextcloud/server#19346
Ref nextcloud/server#15403
Ref nextcloud/server#19485