Skip to content

Move OC.get and OC.set to the bundle - #15403

Merged
MorrisJobke merged 1 commit into
masterfrom
refactor/oc-get-set-bundle
May 7, 2019
Merged

Move OC.get and OC.set to the bundle#15403
MorrisJobke merged 1 commit into
masterfrom
refactor/oc-get-set-bundle

Conversation

@ChristophWurst

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels May 7, 2019
@ChristophWurstChristophWurst added this to the Nextcloud 17 milestone May 7, 2019
@ChristophWurstChristophWurst self-assigned this May 7, 2019

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it used for? 🤔

Code looks good though 😉

@georgehrke

Copy link
Copy Markdown
Member

What exactly is the purpose of OC.get and OC.set? I've never seen anyone use them.

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

I have no idea tbh. It's some pretty old code by @icewind1991: 8990855.

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

https://github.com/orgs/nextcloud/projects/31#card-21153825

@MorrisJobke
MorrisJobke merged commit 5c9b4db into masterMay 7, 2019
@MorrisJobke
MorrisJobke deleted the refactor/oc-get-set-bundle branch May 7, 2019 10:07
ChristophWurst added a commit to nextcloud/documentation that referenced this pull request Apr 10, 2020
Ref nextcloud/server#19455
Ref nextcloud/server#19346
Ref nextcloud/server#15403
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@georgehrke@skjnldsv@MorrisJobke