Skip to content

Document unified search API - #2166

Merged
ChristophWurst merged 1 commit into
masterfrom
enhancement/dev-unified-search
Jun 24, 2020
Merged

Document unified search API#2166
ChristophWurst merged 1 commit into
masterfrom
enhancement/dev-unified-search

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Jun 23, 2020

Copy link
Copy Markdown
Member

@kesselb

Copy link
Copy Markdown
Contributor

cc @marcelklehr@raimund-schluessler does that make sense to you? ;)

@kesselb

Copy link
Copy Markdown
Contributor

Also @korelstar for notes ;)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the enhancement/dev-unified-search branch from 1691bda to e830cebCompareJune 24, 2020 12:40
@marcelklehr

Copy link
Copy Markdown
Member

LGTM.

Currently, a lot of apps override the default search bar in the menu bar to hook in to their custom search functionality. How do we deal with that? Is that functionality expected to be removed in favor of this new search API?

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

Currently, a lot of apps override the default search bar in the menu bar to hook in to their custom search functionality. How do we deal with that? Is that functionality expected to be removed in favor of this new search API?

Most likely, yeah. But the UI part is still to do, so there's a lot that might change. 👀 @skjnldsv@jancborchardt

Ref https://github.com/orgs/nextcloud/projects/38

@ChristophWurst
ChristophWurst merged commit fa52171 into masterJun 24, 2020
@ChristophWurst
ChristophWurst deleted the enhancement/dev-unified-search branch June 24, 2020 13:38
@jancborchardt

Copy link
Copy Markdown
Member

Currently, a lot of apps override the default search bar in the menu bar to hook in to their custom search functionality. How do we deal with that? Is that functionality expected to be removed in favor of this new search API?

Yes, so the idea is that the search bar in the header will become the unified search and work the same anywhere.

In-app search would then move into each app, ideally to the top of the AppNavigation to filter content as-you-type. A great example there is Talk, and the same would be possible design-wise for Files, Mail, Contacts, Activity, Bookmarks, Notes, etc. :)

@skjnldsvskjnldsv mentioned this pull request Aug 3, 2020
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@kesselb@marcelklehr@jancborchardt