Enh/unified search

[skjnldsv]

a	b

API changes

GET https://cloud.domain/search/providers

Now returns a structure like

[{id: 'files',name: 'Files'},{id: 'mails',name: 'Mails'},]

Issues

• Open & focus with ctrl+f
• Auto-focus first result
• No results EmptyContent
• Whole row clickable
• Open in new tab
• Shift header menu a bit to the right

Questions

• Do we need an indicator to display when we reached the end
• How do we sort the results types? Alphabetically?

[nickvergessen]

As for sorting, maybe the current app could be preferred somehow? So in talk Talk results, on files the file results, etc

[jancborchardt]

@nickvergessen absolutely, good call! :) We even discussed that for apps which don’t have their own in-app search, this way they don’t even have to implement their own search but only hook into the unified search.
(Currently only Talk really has a proper in-app search-as-you-type.)

[raimund-schluessler]

As for sorting, maybe the current app could be preferred somehow? So in talk Talk results, on files the file results, etc

For the rest of the apps, I would propose the app order as it is shown in the header (but with current app first ofc.).

[skjnldsv]

Issues:

• First result should open on pressing enter
• Highlight/bold the part in the results list which is a fit
• When searching for folder "Earth", instead of subline "/Photos/Space/Earth" say "in Photos/Space" (but still show the whole item path as subline for Comment results)
• Show folder icons and filetype icons → possibly needs adjustment in the API
• Similar: Comments needs avatar = round, filetypes rounded off. Possibly directly in API.
• Show avatar of person for comment results
• Action icon can go away with whole area being clickable
• Load more results can be color-text-maxcontrast, and remove arrow
• Check on accessibility
• Ellipsize the search input placeholder
• When you type something, then results show, and the first result is focused – you can not type more without focusing the search field again. Is it possible to do this otherwise, to get the benefit of both having focus on the search input, but that enter would open the first result? (We could not put actual focus on the first element, but simply have CSS styles to highlight the first element, and have JS to open the first element on enter?)
• When you tab through the list, then tab back up to the search field, and then tab back down, the first entry is skipped. This is probably directly related to the automatic focus of the first result?
• The emptycontent view says "Start typing to search", better would be "No results for asdf"
• The filetype icon or preview seems to have alt text? This results in a visual bug where the alt text is shown for a split second. Since it’s purely decorative, the alt text should be empty: alt=""

Unrelated:

• Ctrl-F doesn’t work with Text enabled

Follow-up

• Sort results of currently active app first
• Check the additional filters feature, interface for the "in:files" etc

Stuff for future iterations:

• Suggestions as emptycontent e.g. pre-filters
• Ref "sort results of currently active app first" – if it’s well integrated, maybe apps don’t even need their own search in the AppNavigation at all
• See how unified search relates to the Contacts menu (depending on how we improve the Contacts menu)
• Alignment further to the right
• In the case of Files, for a file or folder which is in the current folder we don’t really need to refresh for the scrollto highlight – possible enhancement?

[skjnldsv]

/compile /

[skjnldsv]

Failures seems unrelated!

[georgehrke]

The search icon should remain white even in dark mode.

[nickvergessen]

When you set the theming color to #FFFFFF and #181818 respectively the section headers are invisible on bright/dark theme.

[georgehrke]

An icon size of 44x44 pixels looks a bit big for me:

[marcelklehr]

Bookmarks has its own search currently. Any recommendations on how this should be handled?

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31299: failure

jsunit

Show full log

PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (11.533 secs / 10.988 secs)

[skjnldsv]

Status of 31299: failure

jsunit

curl: (7) Failed to connect to codecov.io port 443: Connection timed out

This is a false negative, we can get this in

Please update again :)

[nickvergessen]

🦈 Bite by bite

[georgehrke]

Très Bien

[raimund-schluessler]

Will there be a migration guide or anything for apps which use the old search already (forgive me if I missed the answer to that)?

[skjnldsv]

Will there be a migration guide or anything for apps which use the old search already (forgive me if I missed the answer to that)?

Yes, there is a documentation start in nextcloud/documentation#2166
And I'm planning to extend it right after this is done :)

[skjnldsv]

BTW: this pr got wrongly merged. I failed the rebase it seems
Fix is in #22088