Move to vue by juliusknorr · Pull Request #106 · nextcloud/firstrunwizard

juliusknorr · 2019-01-08T11:39:31Z

Replaces #102 #100

Requires nextcloud/server#13407

On every page load 1 request 593B

Load about.js (593B) to handle the about menu

On first page load / on click About in menu 1 request 97KB

Load firstrunwizard.js (97KB)

Before 3 requests 39.7 KB

Load firstrunwizard.js (4.1KB)
Load jquery.colorbox.js (29KB)
Load firstrunwizard.js (6.6KB)

ToDo

cleanup css rules
~~maybe just use plain XMLHttpRequest instead of axios (would probably save another 10kb)~~
CSS vars polyfill isn't working for IE11, so we probably need to keep the separate css file

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2019-01-09T13:55:21Z

@jancborchardt Here is the adjusted version with a proper primary button:

jancborchardt

Love the animation! 💥 Also, much better with the blue primary-styled next button. :)

Design-wise 👍, did not review the code.

rullzer · 2019-01-13T19:38:39Z

@juliushaertl awesome!

Does it still launch the first time on a new user?
I'm actually fine with the axios overhead. It will not be loaded all the time now anyway. Which is more than fine but up to you of course.

Signed-off-by: Julius Härtl <jus@bitgrid.net>

rullzer · 2019-01-15T19:29:33Z

+</template>
+<style lang="scss">
+
+	/* Page styling needs to be unscoped, since we load it separately from the server */


This doesn't make sense to me. I do not see how the async loading affects this.. am I missing something or should it just work?

The scoping will not apply since the html from the individual pages is not part of the vue bundle.
As in this screenshot, if the styles are scoped the .page class will get scoped, but it isn't added to the html element, since that one is inserted as plain html using v-html.

If you really want to scope it, you can still manually scope the full css like we do in the components :)

Signed-off-by: Julius Härtl <jus@bitgrid.net>

jancborchardt · 2019-01-16T14:21:54Z

Is anything special required to build/make this or only the core pull request?

Also, could you also test it on dark theme? I just did some fixes – at https://github.com/nextcloud/firstrunwizard/tree/darktheme-fixes cause I forgot this branch exists. ;)

skjnldsv

See comments and the following list: :)

Missing makefile

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fixed

juliusknorr · 2019-01-17T14:21:01Z

@jancborchardt I also fixed the dark mode issues in here. 😉

skjnldsv

Amazing work!! 🚢

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer

Tested and works like a charm with current master. Lets get this in!

jancborchardt · 2019-01-22T11:11:14Z

@juliushaertl nice work! :) Could you add the command to build it to the readme?

juliusknorr added the 2. developing label Jan 8, 2019

juliusknorr added this to the Nextcloud 16 milestone Jan 8, 2019

juliusknorr added 3 commits January 8, 2019 12:41

Move firstrunwizard to vue
50e4e89
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Optimize intro image
778d180
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Remove old firstrunwizard script
0e8b039
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the vue branch from 25a619a to 0e8b039Compare January 8, 2019 11:41

juliusknorr added 6 commits January 8, 2019 13:15

Use image instead on inline embedding for intro image
a0015bc
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Make next button primary
456d43f
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Cleanup CSS
6a4ea3c
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Add vue build checks
8541ba0
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Add linter and fix style errors
0d4c689
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Remove stylesheet loading
4e7597c
Signed-off-by: Julius Härtl <jus@bitgrid.net>

This was referenced Jan 9, 2019
Load colorbox only when needed #100
Closed
Fix resizing issue and move buttons outside of the wizard #102
Closed

jancborchardt approved these changes Jan 9, 2019
View reviewed changes

rullzer reviewed Jan 13, 2019
View reviewed changes

Comment threadpackage.json Outdated

rullzer mentioned this pull request Jan 14, 2019
Allow apps to inline provide inline js nextcloud/server#13570
Open

juliusknorr added 3 commits January 15, 2019 17:56

Properly handle activation script
b18569b
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Update dependencies
257b4ad
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix tests
0b2753e
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr added 3. to review and removed 2. developing labels Jan 15, 2019

juliusknorr requested a review from skjnldsv January 15, 2019 18:59

rullzer reviewed Jan 15, 2019
View reviewed changes

juliusknorr force-pushed the vue branch from fa3907d to bf943b3Compare January 15, 2019 19:44

IE fixes
8c84b0e
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the vue branch from bf943b3 to 8c84b0eCompare January 15, 2019 20:02

juliusknorr mentioned this pull request Jan 15, 2019
Plain javascript api to asynchronously load javascript or css files nextcloud/server#13407
Merged
3 tasks

skjnldsv reviewed Jan 16, 2019
View reviewed changes

Comment thread.eslintrc.js Outdated
Comment threadwebpack.common.js
Comment threadwebpack.dev.js Outdated

skjnldsv previously requested changes Jan 16, 2019
View reviewed changes

jancborchardt mentioned this pull request Jan 17, 2019
Fix first run wizard for dark theme #108
Closed

juliusknorr added 2 commits January 17, 2019 15:01

Improve webpack config
5d783ab
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix dark mode
5d4590c
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the vue branch from 0a40e89 to 5d4590cCompare January 17, 2019 14:21

skjnldsv approved these changes Jan 17, 2019
View reviewed changes

Add assets (in line with other shipped apps)
0eab12b
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer approved these changes Jan 17, 2019
View reviewed changes

rullzer merged commit 34b1a99 into masterJan 17, 2019

rullzer deleted the vue branch January 17, 2019 19:50

juliusknorr mentioned this pull request Jan 21, 2019
First run wizard moves buttons around... #76
Closed

Uh oh!

Conversation

juliusknorr commented Jan 8, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

On every page load 1 request 593B

On first page load / on click About in menu 1 request 97KB

Before 3 requests 39.7 KB

ToDo

Uh oh!

juliusknorr commented Jan 9, 2019

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

rullzer commented Jan 13, 2019

Uh oh!

Uh oh!

rullzerJan 15, 2019

Choose a reason for hiding this comment

Uh oh!

juliusknorrJan 15, 2019

Choose a reason for hiding this comment

Uh oh!

skjnldsvJan 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jancborchardt commented Jan 16, 2019

Uh oh!

skjnldsv left a comment • edited by juliusknorr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Jan 17, 2019

Uh oh!

skjnldsv left a comment

Choose a reason for hiding this comment

Uh oh!

rullzer left a comment

Choose a reason for hiding this comment

Uh oh!

jancborchardt commented Jan 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

juliusknorr commented Jan 8, 2019•
edited
Loading

skjnldsv left a comment •
edited by juliusknorr
Loading