Plain javascript api to asynchronously load javascript or css files by juliusknorr · Pull Request #13407 · nextcloud/server

juliusknorr · 2019-01-07T13:19:31Z

This PR adds a javascript only public API to replace OC.addScript and OC.addStyle (which require jquery) to dynamically load js and css files after the initial loading.

Waiting for #13156 to integrate it into the webpack build.

Uses:

firstrunwizard: Load only when needed Move to vue firstrunwizard#106
richdocuments: Replace use of OC.addScript
files_texteditor: Replace use of OC.addScript

rullzer · 2019-01-10T19:11:19Z

Waiting for #13156 to integrate it into the webpack build.

go go go 🚀

juliusknorr · 2019-01-15T17:17:26Z

@ChristophWurst @skjnldsv I have moved the loader to the webpack build in core/ and made it extend the existing window.OCP object. Should we have this as a separate entrypoint and chunk or keep it in the one bundle for now?

Besides that, it is ready for review.

ChristophWurst · 2019-01-15T17:33:56Z

@ChristophWurst @skjnldsv I have moved the loader to the webpack build in core/ and made it extend the existing window.OCP object. Should we have this as a separate entrypoint and chunk or keep it in the one bundle for now?

I think that is fine for now. We should be able to refactor that and move code around if necessary :)

rullzer · 2019-01-15T20:22:32Z

@ChristophWurst @skjnldsv I have moved the loader to the webpack build in core/ and made it extend the existing window.OCP object. Should we have this as a separate entrypoint and chunk or keep it in the one bundle for now?
I think that is fine for now. We should be able to refactor that and move code around if necessary :)

I agree. Basically the OCP stuff should always be loaded if possible anyway. So makes sense to have this in the dist pack.

rullzer · 2019-01-16T15:53:48Z

So this can go in?

juliusknorr · 2019-01-16T19:34:14Z

Yes, please review.

rullzer

Looks good to me and will make lazy loading much better :D

ChristophWurst

Code looks good!

ChristophWurst · 2019-01-17T08:20:53Z

This will give a nice conflict with #13635 🤐

skjnldsv · 2019-01-17T08:22:30Z

 	if (msie > 0 || trident > 0) {
- cssVars();
+ cssVars({
+ watch: true


poor browser will die of exhaustion ⚰️

pff so be it ;) No need to keep everybody stuck with crappy old stuff just ebcause of IE ;)

MorrisJobke · 2019-01-17T08:59:10Z

Please rebase and rebuild to resolve the conflict.

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fixed

juliusknorr added the 2. developing Work in progress label Jan 7, 2019

juliusknorr requested review from ChristophWurst, rullzer and skjnldsv January 7, 2019 13:19

juliusknorr added the technical debt 🧱 🤔🚀 label Jan 7, 2019

skjnldsv reviewed Jan 7, 2019
View reviewed changes

Comment threadcore/js/loader.js

This was referenced Jan 7, 2019
Load colorbox only when needed nextcloud/firstrunwizard#100
Closed
Move to vue nextcloud/firstrunwizard#106
Merged

kesselb reviewed Jan 10, 2019
View reviewed changes

Comment threadcore/js/loader.js Outdated
Comment threadcore/js/loader.js Outdated

juliusknorr force-pushed the js-async-loading branch 2 times, most recently from 3298dba to 25e658cCompare January 15, 2019 17:11

juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 15, 2019

ChristophWurst reviewed Jan 15, 2019
View reviewed changes

Comment threadcore/js/js.js
Comment threadcore/src/OCP/loader.js Outdated

juliusknorr force-pushed the js-async-loading branch 3 times, most recently from 0dbe21f to b40dd20Compare January 15, 2019 20:15

kesselb reviewed Jan 15, 2019
View reviewed changes

Comment threadcore/src/OCP/loader.js

juliusknorr force-pushed the js-async-loading branch from b40dd20 to 6cbd09fCompare January 15, 2019 21:43

juliusknorr added this to the Nextcloud 16 milestone Jan 15, 2019

rullzer approved these changes Jan 16, 2019
View reviewed changes

ChristophWurst approved these changes Jan 17, 2019
View reviewed changes

skjnldsv reviewed Jan 17, 2019
View reviewed changes

skjnldsv approved these changes Jan 17, 2019
View reviewed changes

rullzer previously requested changes Jan 17, 2019
View reviewed changes

Comment threadcore/src/main.js

juliusknorr added 3 commits January 17, 2019 10:35

Add public API for loading js files asynchronously
a36604d
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Watch for changes with css variables polyfill
a86ee00
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Bump bundled main.js
64b5c0c
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the js-async-loading branch from 6cbd09f to 64b5c0cCompare January 17, 2019 09:36

rullzer merged commit ecc37f5 into masterJan 17, 2019

ChristophWurst mentioned this pull request Jan 17, 2019
Split main js files into modules and add them to the server bundle #13635
Closed

MorrisJobke deleted the js-async-loading branch January 17, 2019 17:03

Uh oh!

Uh oh!

Conversation

juliusknorr commented Jan 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rullzer commented Jan 10, 2019

Uh oh!

Uh oh!

Uh oh!

juliusknorr commented Jan 15, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChristophWurst commented Jan 15, 2019

Uh oh!

rullzer commented Jan 15, 2019

Uh oh!

Uh oh!

rullzer commented Jan 16, 2019

Uh oh!

juliusknorr commented Jan 16, 2019

Uh oh!

rullzer left a comment

Choose a reason for hiding this comment

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Jan 17, 2019

Uh oh!

skjnldsvJan 17, 2019

Choose a reason for hiding this comment

Uh oh!

rullzerJan 17, 2019

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Jan 17, 2019

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

juliusknorr commented Jan 7, 2019•
edited
Loading

juliusknorr commented Jan 15, 2019•
edited
Loading