fix: Incorrect type for empty extraSettings in frontend

[Chartman123]

This fixes an error introduced with the XML fix in #1705

For questions where extraSettings weren't set we got a type mismatch in the extraSettings prop (Object expected, array provided)

[codecov]

Codecov Report

Merging #1730 (4d36422) into main (d2ba5b5) will increase coverage by 42.12%.
The diff coverage is n/a.

Additional details and impacted files

@@ Coverage Diff @@## main #1730 +/- ##
===========================================
+ Coverage 0 42.12% +42.12% - Complexity 0 570 +570 
===========================================
Files 0 55 +55 Lines 0 2381 +2381 ===========================================
+ Hits 0 1003 +1003 - Misses 0 1378 +1378 

[susnux]

Not sure if this is a proper fix or just silencing this error. As the error has a reason: The given type a an array instead of the expected object.

The reason is if the extra settings are empty, php will return an empty assoc. array which will be converted to [] instead of {} for the json.

[susnux]

But I think there is no other good solution, because either we have to fix it when the form is loaded in the frontend.

Or drop XML support (no idea if used, but we should not drop it now).

[Chartman123]

But I think there is no other good solution, because either we have to fix it when the form is loaded in the frontend.

Or drop XML support (no idea if used, but we should not drop it now).

Yes, with this fix the extraSettings prop is either an array[0] or an object depending of the result from the database... Do you see any chance to fix this in the backend and always return an object in JSON?