Skip to content

fix: Enhance extraSettings handling and fix XML output - #1705

Merged
susnux merged 1 commit into
mainfrom
fix/xml_output
Sep 20, 2023
Merged

fix: Enhance extraSettings handling and fix XML output#1705
susnux merged 1 commit into
mainfrom
fix/xml_output

Conversation

@Chartman123

@Chartman123Chartman123 commented Aug 31, 2023

Copy link
Copy Markdown
Collaborator

This fixes#1469

The getExtraSettings() function now returns an associative array so that the XML response of the API is working again.

Furthermore, we now store only set (true) extraSettings to the DB.

@Chartman123

This comment was marked as outdated.

@Chartman123

Copy link
Copy Markdown
CollaboratorAuthor

Ok, I think I found the reason why the XML output breaks... It's the getExtraSettings() in Question.php that returns an object. I think we must refactor the code to work with an associative array here just like for getAccess() in Form.php

@Chartman123
Chartman123force-pushed the fix/xml_output branch 3 times, most recently from 796e5cf to 3956a60CompareSeptember 1, 2023 16:14
@Chartman123Chartman123 changed the title Fix xml outputEnhance extraSettings handling and fix XML outputSep 1, 2023
@codecov

codecovBot commented Sep 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1705 (9ff9533) into main (255c908) will increase coverage by 0.28%.
Report is 3 commits behind head on main.
The diff coverage is 80.00%.

❗ Current head 9ff9533 differs from pull request most recent head 40b2bda. Consider uploading reports for the commit 40b2bda to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## main #1705 +/- ##
============================================
+ Coverage 42.05% 42.33% +0.28% - Complexity 568 570 +2 
============================================
Files 55 55 Lines 2385 2388 +3 ============================================
+ Hits 1003 1011 +8 + Misses 1382 1377 -5 

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123
Chartman123 marked this pull request as ready for review September 1, 2023 17:02
@Chartman123Chartman123 self-assigned this Sep 1, 2023
@Chartman123Chartman123 added bug Something isn't working enhancement New feature or request php PHP related ticket 3. to review Waiting for reviews labels Sep 1, 2023
@Chartman123Chartman123 added this to the 3.4 milestone Sep 1, 2023
@Chartman123Chartman123 changed the title Enhance extraSettings handling and fix XML outputenh: extraSettings handling and fix XML outputSep 1, 2023
@Chartman123Chartman123 changed the title enh: extraSettings handling and fix XML outputfix: Enhance extraSettings handling and fix XML outputSep 1, 2023
@AlexM4H

Copy link
Copy Markdown

Can someone else possibly review the PR as well, or is there something else preventing the merge?

@susnux
susnux merged commit e9aea77 into mainSep 20, 2023
@susnux
susnux deleted the fix/xml_output branch September 20, 2023 14:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugSomething isn't workingenhancementNew feature or requestphpPHP related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: Can not get form in XML format

3 participants

@Chartman123@AlexM4H@susnux