Uh oh!
There was an error while loading. Please reload this page.
fix: Enhance extraSettings handling and fix XML output - #1705
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Chartman123force-pushed
the
fix/xml_output
branch
from
September 1, 2023 14:50
7b7cb3b to
9a91a18CompareChartman123
commented
Sep 1, 2023
CollaboratorAuthor
Ok, I think I found the reason why the XML output breaks... It's the getExtraSettings() in Question.php that returns an object. I think we must refactor the code to work with an associative array here just like for getAccess() in Form.php |
Chartman123force-pushed
the
fix/xml_output
branch
3 times, most recently
from
September 1, 2023 16:14
796e5cf to
3956a60CompareCodecov Report
Additional details and impacted files@@ Coverage Diff @@## main #1705 +/- ##
============================================
+ Coverage 42.05% 42.33% +0.28% - Complexity 568 570 +2
============================================
Files 55 55 Lines 2385 2388 +3 ============================================
+ Hits 1003 1011 +8 + Misses 1382 1377 -5 |
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123force-pushed
the
fix/xml_output
branch
from
September 1, 2023 17:02
9ff9533 to
40b2bdaCompareChartman123
marked this pull request as ready for review
September 1, 2023 17:02
AlexM4H
commented
Sep 8, 2023
Can someone else possibly review the PR as well, or is there something else preventing the merge? |
susnux
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes#1469
The getExtraSettings() function now returns an associative array so that the XML response of the API is working again.
Furthermore, we now store only set (
true) extraSettings to the DB.