Uh oh!
There was an error while loading. Please reload this page.
fix: Make sure "other" answers are correctly handled - #1764
Merged
Conversation
Chartman123
approved these changes
Oct 26, 2023
Chartman123
left a comment
Collaborator
There was a problem hiding this comment.
Code wise this looks good :) I'll test it in the evening on my local instance
Collaborator
My bad... I had entered one of the available values into the other field and that's why it was counted to the predefined option. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #1764 +/- ##
=========================================
Coverage 42.98% 42.98% Complexity 614 614 =========================================
Files 58 58 Lines 2489 2489 =========================================
Hits 1070 1070 Misses 1419 1419 |
Chartman123force-pushed
the
fix/submit-other
branch
from
October 26, 2023 20:34
377dd1f to
1f1ac94CompareIn the backend it handling the "other" answer setting was not changed after switching from object to array for extra settings. In the frontend the value handling of the checkboxes or radio switches was not correct as the initial values is always an empty array. This lead to issues with radio switch answers. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Chartman123force-pushed
the
fix/submit-other
branch
from
October 26, 2023 20:37
1f1ac94 to
8303476Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the backend it handling the "other" answer setting was not changed after switching from object to array for extra settings.
In the frontend the value handling of the checkboxes or radio switches was not correct as the initial values is always an empty array. This lead to issues with radio switch answers.