Uh oh!
There was an error while loading. Please reload this page.
Fix submission of other answers - #1760
Conversation
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
commented
Oct 25, 2023
@AIlkiv Perhaps you could also have another look at this. Current main is broken if you allow custom answers and also the validation on the server side. Statistics are also not counted correctly. @susnux This is my first attempt to fix the problem that I told you about. I'm currently not really sure where this is coming from, might be my change that fixed the output for XML in #1705 |
| </NcCheckboxRadioSwitch> | ||
| <div v-if="allowOtherAnswer" class="question__other-answer"> | ||
| <NcCheckboxRadioSwitch :checked.sync="questionValues" | ||
| <NcCheckboxRadioSwitch :checked.sync="values" |
There was a problem hiding this comment.
This is not valid, you shall not modify properties (values is a property so you should instead only set it like :checked="values" but handle the update with a method like @update:values="onValuesChange"
susnux
commented
Oct 26, 2023
Yes thats at least the reason for the backend issues, for the front end the code was not that error resilient. |
AIlkiv
commented
Oct 29, 2023
@Chartman123 Is the problem still there? Can you provide examples of how to reproduce? |
Chartman123
commented
Oct 29, 2023
@AIlkiv we could already fix it :) it was introduced with my change of the backend to fix XML output |
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de