Uh oh!
There was an error while loading. Please reload this page.
Create Activities - #789
Conversation
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
jotoeri
commented
Feb 22, 2021
Just found a nice trick on Deck, to have separate implementation depending on NC-Version. Now we have the Settings without section for NC<20 and with section for NC>=20 😍 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
commented
Feb 24, 2021
@skjnldsv From my side this is good to go, why developing? |
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
skjnldsv
commented
Feb 24, 2021
Because I thought this was not done :p |
nickvergessen
left a comment
There was a problem hiding this comment.
Looks good, didn't test.
But note you can only use the new type after a release and as far as I know apps can't require patch versions on nextclouds. I therefor would only use it from 21 onwards
jotoeri
commented
Feb 24, 2021
Yeah, i now put the existing type 'highlighted' into the parser. So when to move to the new type will now depend on how far we can backport nextcloud/server#25758 and when we set the corresponding (major-)minversion. I have a ticket open for this. |
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
To remove and replace as soon as NC19 is out of support on Forms. Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Ref. nextcloud/forms#789 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com> Signed-off-by: tsdicloud <bernd.rederlechner@t-systems.com>
Now creating some Activity:
For Submissions, Activities will be merged. Settings are separated into Share & Submission, so Notifications & Emails can be set up separately.
@jancborchardt As usual - i think you have some better wording for the texts? 😉
ActivitySettings.Fixes#12 for now.