Skip to content

Include RichObject for forms - #25758

Merged
nickvergessen merged 1 commit into
masterfrom
enh/include_RichObject_forms
Mar 2, 2021
Merged

Include RichObject for forms#25758
nickvergessen merged 1 commit into
masterfrom
enh/include_RichObject_forms

Conversation

@jotoeri

Copy link
Copy Markdown
Member

Includes the form-richObject for Events/Activities. Ref. nextcloud/forms#789

@nickvergessen I'm not completely sure, what to set as since. I now set 21.0.1 as this seems to me like the 'next' release. However, this PR is now on master (so 22.0.0?), Forms still supports 19, so 19.0.10 with a backport? 🙈

@jotoerijotoeri added the 3. to review Waiting for reviews label Feb 22, 2021
@nickvergessen

Copy link
Copy Markdown
Member

Well this is "public api", it mostly means 22, we so far never backported stuff on it. But then again new things don't break old consumers of the API so should be okay to backport.

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving apart of the since version which we have to clarify

@nickvergessen

Copy link
Copy Markdown
Member

So we also have 11.0.2 on "call" so I guess we can backport this as well.

@jotoeri

Copy link
Copy Markdown
MemberAuthor

So i set this to 19.0.10 then...?

@jotoeri

Copy link
Copy Markdown
MemberAuthor

@nickvergessen Is 19 ok? Or better 20? Unfortunately it depends a bit on this question, when we can start using it. 🙈

@nickvergessen

Copy link
Copy Markdown
Member

If it's up to me I would only put it in 21
you can check it manually in your app by validating a "forms-form" parameter and when valid use it, if not use highlight fallback

Ref. nextcloud/forms#789
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
jotoeriforce-pushed the enh/include_RichObject_forms branch from c69f712 to f02362eCompareMarch 1, 2021 13:01
@jotoeri

Copy link
Copy Markdown
MemberAuthor

Ah, that's sad. But ok. 🤷‍♂️ It's 21 again and i'll have a look onto this validation. 😉

@jotoeri

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer

Copy link
Copy Markdown
Member

Probably wildly off-topic. But is there a reason we need all this in core... wouldn't it be enough if apps can provide such things themselves?

@nickvergessen

Copy link
Copy Markdown
Member

The idea was to have "stable api versioning" with the nextcloud version so if a moible client supports a given version it also doesn't break with any of those parameters but handles them gracefully.

@rullzer

Copy link
Copy Markdown
Member

@nickvergessen you ok now to merge this?

@nickvergessen
nickvergessen merged commit 1a724cb into masterMar 2, 2021
@nickvergessen
nickvergessen deleted the enh/include_RichObject_forms branch March 2, 2021 09:56
@welcome

welcomeBot commented Mar 2, 2021

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jotoeri@nickvergessen@rullzer@skjnldsv