Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Popover to css guidelines - #205
Merged
Merged
Conversation
skjnldsvforce-pushed
the
popover-to-css-guidelines
branch
from
February 12, 2017 04:36
6817339 to
6020d3dCompareSigned-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nextcloud/server#3118
Ps: non related to this pr, but the other icons are still using img. It could be great if you could use span with icon inside instead (see buttons in files for example)