Skip to content

Fit newFileMenu to css guidelines - #3118

Merged
MorrisJobke merged 4 commits into
masterfrom
newFileMenu-css-guidelines
Jan 23, 2017
Merged

Fit newFileMenu to css guidelines#3118
MorrisJobke merged 4 commits into
masterfrom
newFileMenu-css-guidelines

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jan 17, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Following #3114

Two bugs to fix:

  • Why is the label link to the input not working?
  • Why is the new Folder button not working?

@nextcloud/designers please review

@skjnldsvskjnldsv added 2. developing Work in progress design Design, UI, UX, etc. feature: files help wanted labels Jan 17, 2017
@mention-bot

mention-bot commented Jan 17, 2017

Copy link
Copy Markdown

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @MorrisJobke and @butonic to be potential reviewers.

@skjnldsvskjnldsv added this to the Nextcloud 12.0 milestone Jan 17, 2017
@skjnldsv
skjnldsvforce-pushed the newFileMenu-css-guidelines branch from 6829b2b to 606f0c7CompareJanuary 21, 2017 19:06
@skjnldsv

skjnldsv commented Jan 21, 2017•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Before/After
capture d ecran_2017-01-21_20-10-32capture d ecran_2017-01-21_20-10-05

@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress help wanted labels Jan 21, 2017
@skjnldsvskjnldsv self-assigned this Jan 21, 2017
@codecov-io

codecov-io commented Jan 21, 2017•
edited
Loading

Copy link
Copy Markdown

Current coverage is 53.93% (diff: 100%)

Merging #3118 into master will decrease coverage by <.01%

@@ master #3118 diff @@
==========================================
Files 1299 1299 Lines 80145 80145 Methods 7909 7909 Messages 0 0 Branches 1248 1248 ==========================================
- Hits 43228 43227 -1 - Misses 36917 36918 +1 
Partials 0 0

Powered by Codecov. Last update 0d6e3ca...0fc0bcf

MorrisJobke
MorrisJobke previously requested changes Jan 21, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the input field for new file/folder is not hovered anymore it will hide:

bildschirmfoto 2017-01-21 um 17 17 01

@MorrisJobke

MorrisJobke commented Jan 22, 2017

Copy link
Copy Markdown
Member

Works fine with #3187. :)

It's still there. Let's wait for #3187 to be in and then we can continue this one here.

@skjnldsv@MorrisJobke
fit newFileMenu to css guidelines
418ebfb
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv@MorrisJobke
Popover positionning and classes
961fcfa
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv@MorrisJobke
Popover positionning fix
3d86275
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv@MorrisJobke
Popover newFolder input fix
0fc0bcf
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MorrisJobke
MorrisJobkeforce-pushed the newFileMenu-css-guidelines branch from 50d2546 to 0fc0bcfCompareJanuary 22, 2017 17:45
@MorrisJobke

MorrisJobke commented Jan 22, 2017

Copy link
Copy Markdown
Member

I rebased this because #3187 was merged.

@skjnldsv

skjnldsv commented Jan 22, 2017

Copy link
Copy Markdown
MemberAuthor

No conflicts? Lucky you! 😉

@MorrisJobke

MorrisJobke commented Jan 22, 2017

Copy link
Copy Markdown
Member

As said: the weird hidden on hover is still there 😢

@skjnldsv

skjnldsv commented Jan 22, 2017

Copy link
Copy Markdown
MemberAuthor

😕
kazam_screencast_00001

MorrisJobke
MorrisJobke approved these changes Jan 22, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now fine 👍 (I guess some caching issues before, but I really refreshed hard multiple times)

@LukasReschkeLukasReschke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 22, 2017
@MorrisJobke
MorrisJobke merged commit 16afaa7 into masterJan 23, 2017
@MorrisJobke
MorrisJobke deleted the newFileMenu-css-guidelines branch January 23, 2017 02:39
@ChristophWurst

ChristophWurst commented Jan 23, 2017

Copy link
Copy Markdown
Member

Before/After
capture d ecran_2017-01-21_20-10-32 capture d ecran_2017-01-21_20-10-05

The top left corner is not rounded. @skjnldsv could you please fix that? :-)
Also the menu seems to be broken in Gallery (now)

@skjnldsv

skjnldsv commented Jan 23, 2017

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst I saw that for the gallery. Needed to be fixed in the gallery app. On it! :)

This was referenced Jan 26, 2017
Closed
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 12, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@LukasReschkeLukasReschkeLukasReschke approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@schiessleschiessleAwaiting requested review from schiessle

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.feature: filesfeature: scss

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv@mention-bot@codecov-io@MorrisJobke@ChristophWurst@LukasReschke