Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Removed old code already present thanks to the files app - #399

Merged
MorrisJobke merged 2 commits into
masterfrom
fix-share-old-css
Feb 24, 2018
Merged

Removed old code already present thanks to the files app#399
MorrisJobke merged 2 commits into
masterfrom
fix-share-old-css

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Feb 23, 2018

Copy link
Copy Markdown
Member

@skjnldsv
Removed old code already present thanks to the files app
82cbe23
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added design Related to the design 3. to review Waiting for reviews papercut Small issues that doesn't break the ux/ui labels Feb 23, 2018
@skjnldsvskjnldsv self-assigned this Feb 23, 2018
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2018
Closed
@MariusBluemMariusBluem added the backport-request Pending backport by the backport-bot label Feb 24, 2018
@MariusBluem

MariusBluem commented Feb 24, 2018

Copy link
Copy Markdown
Member

Thank you @skjnldsv 😍🙈
Since this is breaking the layout of Files-app, I would vote for backporting this to stable13

@skjnldsv

skjnldsv commented Feb 24, 2018

Copy link
Copy Markdown
MemberAuthor

I agree! :)

@skjnldsv
Popover menu delete button padding fix on files
b34d361
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov

codecovBot commented Feb 24, 2018

Copy link
Copy Markdown

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #399 +/- ##
=========================================
Coverage 82.55% 82.55% Complexity 360 360 =========================================
Files 38 38 Lines 1313 1313 =========================================
Hits 1084 1084 Misses 229 229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b9ed3...b34d361. Read the comment docs.

MorrisJobke
MorrisJobke approved these changes Feb 24, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit fd4caf3 into masterFeb 24, 2018
@MorrisJobke
MorrisJobke deleted the fix-share-old-css branch February 24, 2018 11:55
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Feb 24, 2018
@MorrisJobke

MorrisJobke commented Feb 24, 2018

Copy link
Copy Markdown
Member

Please backport to stable13

@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
Merged
10 tasks
@skjnldsv

skjnldsv commented Mar 9, 2018

Copy link
Copy Markdown
MemberAuthor

Damnit I forgot again!

@skjnldsvskjnldsv mentioned this pull request Mar 9, 2018
Merged
@skjnldsv

skjnldsv commented Mar 9, 2018

Copy link
Copy Markdown
MemberAuthor

Backport in #406

@skjnldsvskjnldsv removed the backport-request Pending backport by the backport-bot label Mar 9, 2018
@skjnldsvskjnldsv mentioned this pull request Mar 9, 2018
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rullzerrullzerAwaiting requested review from rullzer
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@MariusBluemMariusBluemAwaiting requested review from MariusBluem
1 more reviewer
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsdesignRelated to the designpapercutSmall issues that doesn't break the ux/ui

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MariusBluem@MorrisJobke