Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Nov 1, 2020. It is now read-only.
[stable13] Removed old code already present thanks to the files app - #406
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
MorrisJobke, danxuliu, juliusknorr, oparoz and rullzerMarch 9, 2018 10:32
10 tasks
| } | ||
| a.unshare { | ||
| .shareWithList > li > a.unshare { |
Member
There was a problem hiding this comment.
This is an ID instead of a class in my setup somehow 🤔
Member
There was a problem hiding this comment.
Seems to also be the case on master. https://github.com/nextcloud/gallery/blob/master/js/vendor/nextcloud/share.js#L208
Member
There was a problem hiding this comment.
Changing it to #shareWithList:
Before:
After:
Codecov Report
@@ Coverage Diff @@## stable13 #406 +/- ##
===========================================
Coverage 82.27% 82.27% Complexity 335 335 ===========================================
Files 38 38 Lines 1286 1286 ===========================================
Hits 1058 1058 Misses 228 228Continue to review full report at Codecov.
|
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport : Removed old code already present thanks to the files app #399