Uh oh!
There was an error while loading. Please reload this page.
fix: document created in wrong location on public share - #5186
Merged
Conversation
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
requested review from
a team, JuliaKirschenheuter and grnd-alt
and removed request for
a teamNovember 19, 2025 20:45
juliusknorr
approved these changes
Nov 19, 2025
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Nice fix and cleanup at the same time 🚀
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
benjaminfrueh
approved these changes
Nov 19, 2025
Uh oh!
There was an error while loading. Please reload this page.
elzody
commented
Nov 19, 2025
CollaboratorAuthor
/backport to stable32 please |
elzody
commented
Nov 19, 2025
CollaboratorAuthor
/backport to stable31 please |
juliusknorr
commented
Nov 20, 2025
Member
/backport to stable32 please |
juliusknorr
commented
Nov 20, 2025
Member
/backport to stable31 please |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes some front-end code that is no longer necessary since nextcloud/server#54565 was merged. Additionally, it reworks the logic to allow for the entries in the new file menu to show up on public shares.
With all of that being said, documents now get created in the right place, fixing the mentioned issue.
Checklist