Skip to content

feat(file_sharing): Provide template creator list in public shares - #54565

Merged
artonge merged 2 commits into
masterfrom
artonge/feat/support_template_in_public_shares
Sep 8, 2025
Merged

feat(file_sharing): Provide template creator list in public shares#54565
artonge merged 2 commits into
masterfrom
artonge/feat/support_template_in_public_shares

Conversation

@artonge

@artongeartonge commented Aug 21, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

@artonge
artonge requested review from a team and skjnldsv as code ownersAugust 21, 2025 14:23
@artonge
artonge requested review from Altahrim, ArtificialOwl, susnux, szaimen and yemkareems and removed request for a teamAugust 21, 2025 14:23
@artongeartonge self-assigned this Aug 21, 2025
@artongeartonge added enhancement 3. to review Waiting for reviews feature: sharing javascript php Pull requests that update Php code labels Aug 21, 2025
@artonge
artongeforce-pushed the artonge/feat/support_template_in_public_shares branch from b8a12c9 to 55c8d86CompareAugust 21, 2025 14:26
@artonge

artonge commented Aug 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable31

@artonge

artonge commented Aug 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable30

@artonge

artonge commented Aug 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/compile rebase

susnux
susnux reviewed Aug 21, 2025
View reviewed changes
Comment threadapps/files/src/newMenu/newFromTemplate.ts Outdated
@nextcloud-command
nextcloud-commandforce-pushed the artonge/feat/support_template_in_public_shares branch from 55c8d86 to 3bad9d1CompareAugust 21, 2025 15:15
@artonge
artongeforce-pushed the artonge/feat/support_template_in_public_shares branch 3 times, most recently from c84d96e to d22300eCompareAugust 25, 2025 13:14
@artonge
artongeforce-pushed the artonge/feat/support_template_in_public_shares branch 2 times, most recently from 1bc63c1 to ba33875CompareAugust 25, 2025 13:54
@camilasan

camilasan commented Aug 26, 2025

Copy link
Copy Markdown
Member

feedback from @elzody:
The button shows up now in the New File menu, but unable to create a text file. Getting this error:

{
"ocs": {
"meta": {
"status": "failure",
"statuscode": 997,
"message": "Current user is not logged in"
},
"data": []
}
}

Seems like the route is protected and requires a logged-in user even though it's a public share with total edit permissions

@artonge
artongeforce-pushed the artonge/feat/support_template_in_public_shares branch 2 times, most recently from 04dd924 to 760c86fCompareAugust 28, 2025 15:46
@artonge

artonge commented Aug 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@camilasan@elzody just pushed an update, to also handle the file creation. Can you test it?

@camilasan

camilasan commented Sep 1, 2025•
edited
Loading

Copy link
Copy Markdown
Member

@camilasan@elzody just pushed an update, to also handle the file creation. Can you test it?

I again failed to run your changes. I have pinged @elzody for help testing it 😬

elzody
elzody approved these changes Sep 1, 2025
View reviewed changes

@elzodyelzody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a try, it seems to work fine on my end.

@camilasan

camilasan commented Sep 1, 2025

Copy link
Copy Markdown
Member

backport to stable31 now?

@artonge
artongeforce-pushed the artonge/feat/support_template_in_public_shares branch from 760c86f to 01cb346CompareSeptember 4, 2025 10:14
@artonge

artonge commented Sep 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/compile rebase

artongeand others added 2 commits September 4, 2025 12:13
@artonge@nextcloud-command
fix(encryption): Correctly set encrypted to 0 when copying
6d672c4
If encryption got disabled, copying should set encrypted to 0 for the
new unencrypted copy. For instance when using encryption:decrypt-all
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@nextcloud-command
chore(assets): Recompile assets
10d0d0f
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the artonge/feat/support_template_in_public_shares branch from 01cb346 to 10d0d0fCompareSeptember 4, 2025 12:20
@artonge

artonge commented Sep 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport 6d672c4 to stable32

@artonge

artonge commented Sep 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport 6d672c4 to stable31

@artonge
artonge requested a review from susnuxSeptember 4, 2025 14:45
@AndyScherzingerAndyScherzinger added this to the Nextcloud 33 milestone Sep 5, 2025
@artonge
artonge merged commit 491c64d into masterSep 8, 2025
228 of 238 checks passed
@artonge
artonge deleted the artonge/feat/support_template_in_public_shares branch September 8, 2025 10:23
This was referenced Sep 8, 2025
Merged
Merged
Merged
@juliusknorrjuliusknorr mentioned this pull request Oct 14, 2025
Closed
8 tasks
@elzodyelzody mentioned this pull request Nov 19, 2025
Merged
4 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@elzodyelzodyelzody approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner
@szaimenszaimenAwaiting requested review from szaimenszaimen is a code owner automatically assigned from nextcloud/server-frontend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems is a code owner automatically assigned from nextcloud/server-backend
@JuliaKirschenheuterJuliaKirschenheuterAwaiting requested review from JuliaKirschenheuter
@sorbaughsorbaughAwaiting requested review from sorbaugh

Assignees

@artongeartonge

Labels

3. to reviewWaiting for reviewsenhancementfeature: sharingjavascriptphpPull requests that update Php code

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Bring new template file creation to public share links

7 participants

@artonge@camilasan@susnux@elzody@AndyScherzinger@skjnldsv@nextcloud-command